Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix penalty box arc #8

Closed
Torvaney opened this issue Jul 3, 2018 · 5 comments
Closed

Fix penalty box arc #8

Torvaney opened this issue Jul 3, 2018 · 5 comments
Assignees

Comments

@Torvaney
Copy link
Owner

Torvaney commented Jul 3, 2018

The current method of plotting a whole circle behind the penalty box means that on small/distorted pitch shapes, the circle can peek out from behind the goal:

rplot01

As part of the same issue, the circles change size (relative to the rest of the pitch) depending on the size/aspect ratio of the pitch. This should be avoided if possible.

Perhaps there's a clean solution using annotate?

@Torvaney Torvaney self-assigned this Jul 3, 2018
@Torvaney
Copy link
Owner Author

Alternatively, we could continue to use annotation_custom but change the grob to use grid::grid.path

@Torvaney
Copy link
Owner Author

Or could add a viewport (arg to circleGrob) to clip the circle -> semi-circle

@Torvaney
Copy link
Owner Author

Or we could use data (generated from the pitch spec) to plot a circle (or an oval due to the coordinates)

@Torvaney
Copy link
Owner Author

or could just use ggforce 🤷‍♂

@Torvaney
Copy link
Owner Author

another false alarm :/

@Torvaney Torvaney reopened this May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant