Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better links to MomentJS documentation #34

Closed
TotallyInformation opened this issue Jun 25, 2020 · 2 comments
Closed

Add better links to MomentJS documentation #34

TotallyInformation opened this issue Jun 25, 2020 · 2 comments

Comments

@TotallyInformation
Copy link
Owner

This node uses MomentJS to do all the heavy lifting. Both the available formats and the available Timezones come from that package.

While there is a link to the docs in the help sidebar, it might be nice to have an icon/link to the appropriate help information for both the formats inputs and the timezones inputs.

Timezones might have to link back to the GitHub repo for MomentJS, not sure if they are documented elsewhere other than the definition file.

This would make a great starter task for anyone wanting to help with maintaining/enhancing the moment node.

Thanks to @dceejay for the prompt:

while we don't encourage it (as it won't work offline) - in this case it may be useful to have a small (i) icon to the right of that field to link direct to that docs page as everyone will need it - and it would shortcut reading the help info.

Finally likewise the timezones - the info says "check the valid timezone list built in to moment-timezone" - err where / how do I do that ? do you have a link ? (or should it be a select box ?)

@StephanStS
Copy link
Contributor

Is the updated documentation with several links to moment.js in my fork (https://github.com/StephanStS/node-red-contrib-moment) a solution?
I put this docu rework into pull request #38.

@TotallyInformation
Copy link
Owner Author

Incorporated into v4 due to be released shortly & already in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants