Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Start Minimized Options #186

Open
insomnimatic opened this issue Nov 15, 2022 · 3 comments
Open

Feature Request: Start Minimized Options #186

insomnimatic opened this issue Nov 15, 2022 · 3 comments
Labels
enhancement New feature or enhancement request good first issue Good for newcomers UI/UX/Qt Relates to Qt, visuals and user interactions

Comments

@insomnimatic
Copy link

I think it would probably be convenient to have an option to start the Auto-Split window minimized and / or in the hidden icon tray.

I figured this would be a nice feature to have included with the Auto-Split + LiveSplit bundle, since it would save some processing power, it would automatically help eliminate screen clutter, and basically since once you have the split screenshots and settings figured out, there's really no reason to always have the window open.

It's not a super fancy feature request, but I figured it would be worth a shot.

@Avasam
Copy link
Collaborator

Avasam commented Nov 15, 2022

Sounds reasonable :)

We're feature-freezing right now for 2.0.0. And focusing on bugfixes. But I like this feature request.

@insomnimatic
Copy link
Author

I've never really done any work here on GitHub, but I could probably take the source and add a new option for "Always Start Minimized". I love me some Python, so I'll give it a shot.

Since I've never really added anything on here, I'm not sure how to update or.. I guess the right term would be to create a "fork" or "Commit". I don't want to screw anything up in that regard, so i'll post it here, if you'd like to patch it in for an update.

Thank you for taking the time to look at the request, I really do appreciate it.

@Avasam
Copy link
Collaborator

Avasam commented Nov 16, 2022

@insomnimatic Since you don't have write access to this repo (I don't even have), you can't screw anything. Worst that can happen is that your work is not accepted.
As for the usual workflow, it's Create a fork -> Clone it -> Do your changes -> Stage+Commit+Push -> Create a Pull Request from the branch in your fork containing changes back to the upstream repo (usually to a branch main/master, develop, etc.) and wait for review.

As for how I see this feature work: A command line argument sounds useful for third-party integration (like livesplit). And maybe storing the option using Qt instead or the user profile (like we do for update checking)

@Avasam Avasam added enhancement New feature or enhancement request good first issue Good for newcomers UI/UX/Qt Relates to Qt, visuals and user interactions labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement request good first issue Good for newcomers UI/UX/Qt Relates to Qt, visuals and user interactions
Projects
None yet
Development

No branches or pull requests

2 participants