Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix between SMD and THT ends up in SMD only footprint #1

Closed
Bouni opened this issue Dec 30, 2021 · 3 comments
Closed

Mix between SMD and THT ends up in SMD only footprint #1

Bouni opened this issue Dec 30, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Bouni
Copy link

Bouni commented Dec 30, 2021

Hi,

first of all, this is absolutely amazing! I totally love this project 馃槏

I tried to get footprint, symbol and 3D file for the USB Micro connector C132563 which should look like this:

image

The Symbol is correct:

image

But the footprint is not:

image

The 3D Package turned out great:

image

But there are two minor issues with the 3D package:

  1. The path that is put into the footprint is an absolute path, so If I generate the part lets say in C:\temp\footprints... , that path is put into the footprint. It breaks as soon as I move the package to another location.
  2. The position of the 3D model in relation to the footprint is not correct and needs to be adjusted manually, but I have no idea if thats even automatically possible.
@TousstNicolas TousstNicolas added the bug Something isn't working label Dec 30, 2021
@TousstNicolas
Copy link
Owner

Thank you for the comment and reporting this issue. I corrected the missing holes for SMD-THT mixed components.

I had no problem with the 3d model path on my side as long as the package is not moved, can you specify what the problem is on your side?

I have added a --model_path_relative option which allows if it is present, to give the relative 3d model path. It is then formed as: {output_dir/footprint_dir}/packages3d/{footprint_name}
Let me now if you think there is a better solution.

@Bouni
Copy link
Author

Bouni commented Dec 31, 2021

Let me check this next week and I'll happily give you feedback!
Keep up the good work 馃槉

@Bouni
Copy link
Author

Bouni commented Jan 13, 2022

Sorry for the late reply, I can confirm that the --model_path_relative switch works as expected!

@Bouni Bouni closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants