Spiral Lane integration #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
6 tasks
- Fix heading. - Fix regression tests. - Fix integration tests. Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
|
c211f7e fixes the ground curve issues. Now, it is loading with the right tolerance. |
Signed-off-by: Agustin Alba Chicar <ag.albachicar@gmail.com>
|
1fae479 should fix the bazel pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Solves #265
Summary
Integrates the SpiralGroundCurve into the builder to get RoadGeometries that support that ground geometry.
Note that there are still some issues with tolerances which are underlying to the implementation in #276. The integration is achieved but the tolerance level is extremely high for SmallTownRoads.xodr at the moment.Picture of an intersection with spiral geometries from SmallTownRoads.xodr
Full mesh file:
SmallTownRoadsMesh.zip
Test it
Via unit and integration tests.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.