-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic table component based on react-window #73
Comments
@danjohnson77 I assigned this one to you as you are familiar with react-window. Let me know it it is OK with you? :) |
@atompie Yeah looks good, especially if row height can be static. Will take a look with fresh eyes in the morning and send questions but shouldn't be a problem. |
Thanks |
I'm looking into React window now. It seems straightforward. Do we need lazy-loading too? Can I be assigned the issue? |
@Bruce-Hopkins Yes lazy loading would be great. |
Right now the table is a single row. Should it be multiple rows? I was also thinking about being able to pass into the props the color of the row, (right now every odd-numbered row is white and every even-numbered row is yellow.) |
We need a generic table component that we could use to display data. The data can be huge so using react-window is a must (https://github.com/bvaughn/react-window).
Row height will not be variant - this is the requirement for react-window. This component should auto load on scroll.
It should be flexible enough to add new columns. It could look like this.
Maybe the children needs to be a function like this (if react window needs this):
This is up to you how you structure the component as long as it is flexible enough to pass data and modify the display of single column.
The text was updated successfully, but these errors were encountered: