-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Bazel unit test CI #342
Refactor Bazel unit test CI #342
Conversation
FYI cache reuse runtimes are in the workflows here (the ones that take ~50 seconds 😈) aaronmondal#3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)
.github/workflows/unit-test.yaml
line 50 at r1 (raw file):
run: | if [ "$RUNNER_OS" == "Linux" ] || [ "$RUNNER_OS" == "macOS" ]; then bazel test ...
nit: bazel test //...
.github/workflows/unit-test.yaml
line 56 at r1 (raw file):
test \ --config=windows \ ...
nit: //...
Unify workflows for Unix and Windows and use more efficient caching for workflow artifacts. Harden the workflow with fixed action hashes. Reduces Linux workflow runtime to ~1 min for best-case cache hits.
34bdbc0
to
ec3fa74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @allada and @MarcusSorealheis)
.github/workflows/unit-test.yaml
line 50 at r1 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
nit:
bazel test //...
Done. Ah damn I prefer the ...
syntax much more, but there can be compatibility issues with some shells (I believe zsh) that interpret triple dots in a different way. So the //...
is the more compatible way to go 😞
Unify workflows for Unix and Windows and use more efficient caching for workflow artifacts. Harden the workflow with fixed action hashes. Reduces Linux workflow runtime to ~1 min for best-case cache hits.
Unify workflows for Unix and Windows and use more efficient caching for workflow artifacts. Harden the workflow with fixed action hashes. Reduces Linux workflow runtime to ~1 min for best-case cache hits.
Unify workflows for Unix and Windows and use more efficient caching for workflow artifacts. Harden the workflow with fixed action hashes.
Reduces Linux workflow runtime to ~1 min for best-case cache hits.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)