Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Bazel unit test CI #342

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Oct 26, 2023

Unify workflows for Unix and Windows and use more efficient caching for workflow artifacts. Harden the workflow with fixed action hashes.

Reduces Linux workflow runtime to ~1 min for best-case cache hits.


This change is Reviewable

@aaronmondal
Copy link
Member Author

FYI cache reuse runtimes are in the workflows here (the ones that take ~50 seconds 😈) aaronmondal#3

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)


.github/workflows/unit-test.yaml line 50 at r1 (raw file):

        run: |
          if [ "$RUNNER_OS" == "Linux" ] || [ "$RUNNER_OS" == "macOS" ]; then
            bazel test ...

nit: bazel test //...


.github/workflows/unit-test.yaml line 56 at r1 (raw file):

              test \
              --config=windows \
              ...

nit: //...

Unify workflows for Unix and Windows and use more efficient caching for
workflow artifacts. Harden the workflow with fixed action hashes.

Reduces Linux workflow runtime to ~1 min for best-case cache hits.
Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @allada and @MarcusSorealheis)


.github/workflows/unit-test.yaml line 50 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

nit: bazel test //...

Done. Ah damn I prefer the ... syntax much more, but there can be compatibility issues with some shells (I believe zsh) that interpret triple dots in a different way. So the //... is the more compatible way to go 😞

@aaronmondal aaronmondal merged commit ef794c2 into TraceMachina:main Oct 26, 2023
14 of 15 checks passed
blakehatch pushed a commit to blakehatch/nativelink that referenced this pull request Nov 14, 2023
Unify workflows for Unix and Windows and use more efficient caching for
workflow artifacts. Harden the workflow with fixed action hashes.

Reduces Linux workflow runtime to ~1 min for best-case cache hits.
blakehatch pushed a commit to blakehatch/nativelink that referenced this pull request Nov 21, 2023
Unify workflows for Unix and Windows and use more efficient caching for
workflow artifacts. Harden the workflow with fixed action hashes.

Reduces Linux workflow runtime to ~1 min for best-case cache hits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants