Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README for discoverability. #349

Merged

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Oct 28, 2023

Description

The Bazel documentation and ecosystem more commonly refer to the remote execution protocol as the RBE.

Type of change

Documentation.

  • This change requires a documentation update

This change is Reviewable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @allada and @MarcusSorealheis)


-- commits line 2 at r1:
Nit: "Update README for visibility" (caps and no period) 😅


README.md line 15 at r1 (raw file):

## Overview

Turbo Cache is a project that implements the [Bazel Remote Execution protocol](https://github.com/bazelbuild/remote-apis) (both CAS/Cache and remote execution portion).

Hahaha we were doing it wrong all along!

What about this part though? Isn't it actually Remote Build Execution then? That would also make more sense since the RBE is technically build system agnostic.

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)


README.md line 15 at r1 (raw file):

Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…

Hahaha we were doing it wrong all along!

What about this part though? Isn't it actually Remote Build Execution then? That would also make more sense since the RBE is technically build system agnostic.

It's technically both. RBE is more generic, BRE is specific to bazel.

@MarcusSorealheis MarcusSorealheis merged commit 5e2e81a into TraceMachina:main Oct 29, 2023
13 of 14 checks passed
blakehatch pushed a commit to blakehatch/nativelink that referenced this pull request Nov 14, 2023
blakehatch pushed a commit to blakehatch/nativelink that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants