Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Http2 flags for advanced configurations #365

Merged
merged 1 commit into from Nov 2, 2023
Merged

Conversation

allada
Copy link
Collaborator

@allada allada commented Oct 31, 2023

Some users will want to tune advanced http2 configurations. This PR gives that ability.


This change is Reviewable

Some users will want to tune advanced http2 configurations.
This PR gives that ability.
Copy link
Collaborator Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@blakehatch

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @blakehatch)

Copy link
Contributor

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @allada)


cas/cas_main.rs line 467 at r1 (raw file):

        if let Some(value) = http_config.http2_max_header_list_size {
            http.http2_max_header_list_size(value);
        }

Would just need another case for the http2_only method here if adding it is of interest.


config/cas_server.rs line 212 at r1 (raw file):

/// specified.
#[derive(Deserialize, Debug, Default)]
pub struct HttpServerConfig {

https://docs.rs/hyper/latest/hyper/server/conn/struct.Http.html#method.http2_only

Only method in the crate not currently supported by this config is http2_only, not necessary for feature completeness here but restricting to just http2 could maybe have it's uses.

Copy link
Collaborator Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @blakehatch)


cas/cas_main.rs line 467 at r1 (raw file):

Previously, blakehatch (Blake Hatch) wrote…

Would just need another case for the http2_only method here if adding it is of interest.

I thought about it, but decided that it's unlikely to ever be used.


config/cas_server.rs line 212 at r1 (raw file):

Previously, blakehatch (Blake Hatch) wrote…

https://docs.rs/hyper/latest/hyper/server/conn/struct.Http.html#method.http2_only

Only method in the crate not currently supported by this config is http2_only, not necessary for feature completeness here but restricting to just http2 could maybe have it's uses.

(see above)

Copy link
Contributor

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @allada)


cas/cas_main.rs line 467 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

I thought about it, but decided that it's unlikely to ever be used.

Done


config/cas_server.rs line 212 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

(see above)

Done

Copy link
Contributor

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @allada)

@blakehatch blakehatch merged commit cb04ed4 into main Nov 2, 2023
14 checks passed
@blakehatch blakehatch deleted the support-http-flags branch November 2, 2023 19:58
blakehatch pushed a commit to blakehatch/nativelink that referenced this pull request Nov 21, 2023
Some users will want to tune advanced http2 configurations.
This PR gives that ability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants