Add DigestHasher as interface to hashing functions #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allada
commented
Nov 16, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, all discussions resolved (waiting on @aaronmondal and @blakehatch)
aaronmondal
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @blakehatch)
allada
force-pushed
the
add-digest-hasher
branch
from
3e9241f
to
b80c8db
Compare
Adds DigestHasher and hashing implementation for Sha256. This will be used to abstract the different hashing algos when computing digests. towards: #191
allada
force-pushed
the
add-digest-hasher
branch
from
b80c8db
to
55c2e4b
Compare
allada
commented
Nov 19, 2023
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status:
TripleKai
pushed a commit
to TripleKai/turbo-cache
that referenced
this pull request
Nov 29, 2023
Adds DigestHasher and hashing implementation for Sha256. This will be used to abstract the different hashing algos when computing digests. towards: TraceMachina#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DigestHasher and hashing implementation for Sha256. This will be used to abstract the different hashing algos when computing digests.
towards: #191
This change is