Rename Turbo Cache to Native Link #402
Conversation
MarcusSorealheis
force-pushed
the
rename-turbocache
branch
2 times, most recently
from
c6c5936
to
52e4d99
Compare
There was a problem hiding this comment.
Reviewed 6 of 237 files at r1.
Reviewable status: 6 of 238 files reviewed, 2 unresolved discussions (waiting on @allada and @MarcusSorealheis)
-- commits line 2 at r1:
Nit: Remove trailing period.
README.md line 3 at r1 (raw file):
# Native Link [](https://github.com/trace_machina/native-link/actions/workflows/main.yml)
This (and probably a bunch of other places) is an invalid link. trace_machina -> TraceMachina.
There was a problem hiding this comment.
Reviewable status: 6 of 238 files reviewed, 2 unresolved discussions (waiting on @aaronmondal and @allada)
README.md line 3 at r1 (raw file):
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
This (and probably a bunch of other places) is an invalid link.
trace_machina->TraceMachina.
I think this was resolved just before you reviewed the PR, see: 52e4d99
MarcusSorealheis
changed the title
MarcusSorealheis
force-pushed
the
rename-turbocache
branch
from
52e4d99
to
d9c5b8e
Compare
There was a problem hiding this comment.
Reviewed 231 of 237 files at r1, 16 of 18 files at r2, 101 of 101 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @allada and @MarcusSorealheis)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @allada and @MarcusSorealheis)
Description
This PR renames turbo-cache to be native link as this project has expanded well beyond build caching.
Fixes # (issue)
Type of change
rename
not work as expected)
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...passes locallygit amendsee some docsThis change is