Add Noop store #408
Add Noop store #408
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @aaronmondal)
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @allada)
config/examples/basic_cas.json line 18 at r1 (raw file):
"filesystem": { "content_path": "/tmp/turbo_cache/data-worker-test/content_path-cas", "temp_path": "/tmp/turbo_cache/data-worker-test/tmp_path-cas",
nit: native_link
config/examples/basic_cas.json line 70 at r1 (raw file):
"ac_store": "AC_MAIN_STORE", }, "work_directory": "/tmp/turbo_cache/work",
nit: native_link
allada
force-pushed
the
add-noop-store
branch
2 times, most recently
from
447bc11
to
d09ec6e
Compare
There was a problem hiding this comment.
Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @aaronmondal)
config/examples/basic_cas.json line 18 at r1 (raw file):
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
nit:
native_link
Done.
config/examples/basic_cas.json line 70 at r1 (raw file):
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
nit:
native_link
Done.
Adds a Noop Store that sends data to the void and always returns 404 (NotFound). closes #385
allada
force-pushed
the
add-noop-store
branch
from
d09ec6e
to
abff318
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
Adds a Noop Store that sends data to the void and always returns 404 (NotFound). closes TraceMachina#385
Adds a Noop Store that sends data to the void and always returns 404 (NotFound).
closes #385
This change is