Move action_messages & part of platform_properties to utils crate #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allada
force-pushed
the
move-action-messages
branch
from
a340170
to
9c3d05e
Compare
allada
commented
Nov 26, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 31 files reviewed, all discussions resolved (waiting on @aaronmondal)
allada
force-pushed
the
move-action-messages
branch
from
9c3d05e
to
03cbe65
Compare
Moves action_messages helper and part of the platform properties to the utils crate so it can be used in stores.
allada
force-pushed
the
move-action-messages
branch
from
03cbe65
to
5e5df35
Compare
aaronmondal
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
FYI When building with Buck2 the json5 dependency caused issues and I changed it to serde_jsonrc whith which it now builds, but fails to parse the platform configs. This change might make it easier to port to that library.
Reviewed 31 of 31 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
TripleKai
pushed a commit
to TripleKai/turbo-cache
that referenced
this pull request
Nov 29, 2023
…aceMachina#417) Moves action_messages helper and part of the platform properties to the utils crate so it can be used in stores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves action_messages helper and part of the platform properties to the utils crate so it can be used in stores.
This change is