Fix empty bytes error in s3 store and support AWS_ENDPOINT_URL #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allada
commented
Nov 27, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @aaronmondal)
Some http servers can send empty strings in the stream, but we do not allow this in our code since this is the EOF signal. Also adds ability to use custom AWS_ENDPOINT_URL env to change destination of s3 endpoint.
allada
changed the title
aaronmondal
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
aaronmondal
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Reviewable status:
TripleKai
pushed a commit
to TripleKai/turbo-cache
that referenced
this pull request
Nov 29, 2023
…Machina#421) Some http servers can send empty strings in the stream, but we do not allow this in our code since this is the EOF signal. Also adds ability to use custom AWS_ENDPOINT_URL env to change destination of s3 endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some http servers can send empty strings in the stream, but we
do not allow this in our code since this is the EOF signal.
Also adds ability to use custom AWS_ENDPOINT_URL env to change
destination of s3 endpoint.
This change is