Add hadolint to pre-commit hooks #422
Conversation
aaronmondal
force-pushed
the
hadolint
branch
2 times, most recently
from
ab0a1a0
to
5950085
Compare
There was a problem hiding this comment.
I thought about it, and the only issue I see in this PR is that there is no mention of Hadolint in the docker-compose README. Then it dawned me on that we don't have a README for this directory. I've created a new issue here
LGTM
|
|
||
| RUN apt-get update && \ | ||
| DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \ | ||
| npm=8.5.1~ds \ |
There was a problem hiding this comment.
this is a huge improvement
There was a problem hiding this comment.
Even if it seems small
aaronmondal
force-pushed
the
hadolint
branch
6 times, most recently
from
61f4020
to
5708dab
Compare
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronmondal)
deployment-examples/docker-compose/Dockerfile line 74 at r2 (raw file):
DEBIAN_FRONTEND=noninteractive \ apt-get install --no-install-recommends -y \ ca-certificates=20230311ubuntu0.22.04.1; \
nit: Not needed any more, right?
aaronmondal
force-pushed
the
hadolint
branch
from
5708dab
to
988a0d4
Compare
There was a problem hiding this comment.
Dismissed @MarcusSorealheis from a discussion.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @aaronmondal)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aaronmondal)
This hardens the Dockerfile.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Reviewable status:
deployment-examples/docker-compose/Dockerfile line 74 at r2 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
nit: Not needed any more, right?
Unfortunately still needed. Will attempt to remove it #708
This hardens the Dockerfile.
This change is