Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel enable aarch64-apple-darwin by adding to crates repository supported platforms #440

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

adam-singer
Copy link
Member

@adam-singer adam-singer commented Dec 1, 2023

Description

Enable running rust tests on Apple Silicon.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

CARGO_BAZEL_REPIN=true bazel test //...

Please also list any relevant details for your test configuration

Checklist

  • [] bazel test //... passes locally

NOTE: Not all tests pass locally, this could be an indication of bug with implementation/test on osx.

//native-link-worker:integration_tests/local_worker_test                 FAILED in 0.5s
  /private/var/tmp/_bazel_adam/40c88777425c71ea9813d14d612023d6/execroot/native-link/bazel-out/darwin_arm64-fastbuild/testlogs/native-link-worker/integration_tests/local_worker_test/test.log
//native-link-worker:integration_tests/running_actions_manager_test      FAILED in 0.7s
  /private/var/tmp/_bazel_adam/40c88777425c71ea9813d14d612023d6/execroot/native-link/bazel-out/darwin_arm64-fastbuild/testlogs/native-link-worker/integration_tests/running_actions_manager_test/test.log

This change is Reviewable

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to dig in here to try and understand why. Now feels early.

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test in running_actions_manager is known to be flaky. However, if it consistently fails on MacOS it might help find out why. We should probably add some kind of MacOS test to CI so that we can "officially" support MacOS (#345). But that can wait for a later commit.

:lgtm: ❤️

PS: The repo uses squash merging by default. Sometimes this can wrongly lead to the entire PR description (including the PR template) being added to the commit message, or randomly completely omit the message. Take care review the commit message when merging 😅

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adam-singer)

@adam-singer
Copy link
Member Author

would be good to dig in here to try and understand why. Now feels early.

I'm not sure this is specific to bazel, I notice the same failures with cargo on osx

https://gist.github.com/adam-singer/2a947561295e3eef5f309e2646076753
https://gist.github.com/adam-singer/484a56f87d67ef8847464f80d066585a

I think we can fix the tests independent of this patch, also not in a rush to land this

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adam-singer)

@adam-singer adam-singer marked this pull request as ready for review December 1, 2023 23:53
Copy link
Member Author

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronmondal is there a rule we follow for the squashed commit? ie, do we want a shorten description or ensure the full description from github is serialized into the commit message? When using phabricator I liked how description was by defaulted as the commit message with back links to the review page, issue tracker and other metadata in the commit message.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adam-singer)

@adam-singer adam-singer merged commit ff6d5cf into TraceMachina:main Dec 2, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants