-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel enable aarch64-apple-darwin by adding to crates repository supported platforms #440
Bazel enable aarch64-apple-darwin by adding to crates repository supported platforms #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to dig in here to try and understand why. Now feels early.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test in running_actions_manager is known to be flaky. However, if it consistently fails on MacOS it might help find out why. We should probably add some kind of MacOS test to CI so that we can "officially" support MacOS (#345). But that can wait for a later commit.
PS: The repo uses squash merging by default. Sometimes this can wrongly lead to the entire PR description (including the PR template) being added to the commit message, or randomly completely omit the message. Take care review the commit message when merging 😅
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @adam-singer)
I'm not sure this is specific to bazel, I notice the same failures with cargo on osx https://gist.github.com/adam-singer/2a947561295e3eef5f309e2646076753 I think we can fix the tests independent of this patch, also not in a rush to land this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @adam-singer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronmondal is there a rule we follow for the squashed commit? ie, do we want a shorten description or ensure the full description from github is serialized into the commit message? When using phabricator I liked how description was by defaulted as the commit message with back links to the review page, issue tracker and other metadata in the commit message.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @adam-singer)
Description
Enable running rust tests on Apple Silicon.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...
passes locallyNOTE: Not all tests pass locally, this could be an indication of bug with implementation/test on osx.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)