Remove caching from native cargo action #458
Conversation
If we share caches between workflows, the runners run out of storage. If we separate the caches we have too many of them and keep stepping over GitHub's cache limitations. Remove caching entirely as this workflows doesn't take *that* long and we need the caches for Bazel and Nix.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @aaronmondal)
-- commits line 4 at r1:
shall we instead just pay for more storage?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @allada)
Previously, allada (Nathan (Blaise) Bruer) wrote…
shall we instead just pay for more storage?
I think at this point it makes sense to use larger runners. We can't increase the size of the GHA cache, but e.g. having 4 or 8 cores and a few gigs more ram and storage would obsolete any cache issues we have at the moment since things would build fast enough from scratch that we don't need caching anymore.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aaronmondal)
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
I think at this point it makes sense to use larger runners. We can't increase the size of the GHA cache, but e.g. having 4 or 8 cores and a few gigs more ram and storage would obsolete any cache issues we have at the moment since things would build fast enough from scratch that we don't need caching anymore.
Crazy you can't pay for more storage.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
If we share caches between workflows, the runners run out of storage. If we separate the caches we have too many of them and keep stepping over GitHub's cache limitations. Remove caching entirely as this workflows doesn't take that long and we need the caches for Bazel and Nix.
This change is