Removes Dash from our Name for Simplicity

[MarcusSorealheis]

Description

renames everything but need to generate new protos.

Fixes # (issue)

Type of change

Docs

Please delete options that are not relevant.

• Breaking change (fix or feature that would cause existing functionality to
  not work as expected)
• This change requires a documentation update

How Has This Been Tested?

CI

Checklist

• Updated documentation if needed
• Tests added/amended
• bazel test //... passes locally
• PR is contained in a single commit, using git amend see some docs

---

This change is 

[MarcusSorealheis]

fixed protos

[blakehatch]

Lots of errors with screaming snake case, I would figure out a way to replace "nativelink_" with "NATIVELINK_" although there are a smaller number of cases where it is regular snake case and shouldn't be replaced. Probably should figure out how to grep whether the character after _ is lowercase or not to handle that case.

Reviewed 163 of 166 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 103 unresolved discussions (waiting on @aaronmondal, @allada, and @MarcusSorealheis)

---

run_integration_tests.sh line 87 at r2 (raw file):

DID_FAIL=0

export nativelink_DIR="$CACHE_DIR/nativelink"

Fix screaming snake case so it is "NATIVELINK_DIR"

---

run_integration_tests.sh line 93 at r2 (raw file):

  find "$SELF_DIR/integration_tests/" -name "$pattern" -type f -print0 | while IFS= read -r -d $'\0' fullpath; do
    # Cleanup.
    echo "Cleaning up cache directories TURBOC_CACHE_DIR: $nativelink_DIR"

ditto

---

run_integration_tests.sh line 94 at r2 (raw file):

    # Cleanup.
    echo "Cleaning up cache directories TURBOC_CACHE_DIR: $nativelink_DIR"
    echo "Checking for existince of the nativelink_DIR"

ditto

---

run_integration_tests.sh line 95 at r2 (raw file):

    echo "Cleaning up cache directories TURBOC_CACHE_DIR: $nativelink_DIR"
    echo "Checking for existince of the nativelink_DIR"
    if [ -d "$nativelink_DIR" ]; then

ditto

---

run_integration_tests.sh line 96 at r2 (raw file):

    echo "Checking for existince of the nativelink_DIR"
    if [ -d "$nativelink_DIR" ]; then
      sudo find "$nativelink_DIR" -delete

ditto

---

run_integration_tests.sh line 98 at r2 (raw file):

      sudo find "$nativelink_DIR" -delete
    else
      echo "Directory $nativelink_DIR does not exist."

ditto

---

deployment-examples/docker-compose/docker-compose.yml line 27 at r2 (raw file):

        - ADDITIONAL_SETUP_WORKER_CMD=${ADDITIONAL_SETUP_WORKER_CMD:-}
    volumes:
      - ${nativelink_DIR:-~/.cache/nativelink}:/root/.cache/nativelink

Fix screaming snake case

---

deployment-examples/docker-compose/docker-compose.yml line 65 at r2 (raw file):

        - ADDITIONAL_SETUP_WORKER_CMD=${ADDITIONAL_SETUP_WORKER_CMD:-}
    volumes:
      - ${nativelink_DIR:-~/.cache/nativelink}:/root/.cache/nativelink

Fix screaming snake case

---

deployment-examples/docker-compose/README.md line 46 at r2 (raw file):

        - ADDITIONAL_SETUP_WORKER_CMD=${ADDITIONAL_SETUP_WORKER_CMD:-}
    volumes:
      - ${nativelink_DIR:-~/.cache/nativelink}:/root/.cache/nativelink

Fix screaming snake case

---

deployment-examples/docker-compose/README.md line 102 at r2 (raw file):

        - ADDITIONAL_SETUP_WORKER_CMD=${ADDITIONAL_SETUP_WORKER_CMD:-}
    volumes:
      - ${nativelink_DIR:-~/.cache/nativelink}:/root/.cache/nativelink

Fix screaming snake case

---

deployment-examples/terraform/AWS/scripts/cas.json line 13 at r2 (raw file):

              "memory": {
                "eviction_policy": {
                  "max_bytes": "${nativelink_AC_CONTENT_LIMIT:-100000000}",

Fix screaming snake case

---

deployment-examples/terraform/AWS/scripts/cas.json line 23 at r2 (raw file):

              // to distinguish each shard based on the key.
              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/cas.json line 24 at r2 (raw file):

              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",
                "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/cas.json line 47 at r2 (raw file):

                  "memory": {
                    "eviction_policy": {
                      "max_bytes": "${nativelink_CAS_INDEX_CACHE_LIMIT:-100000000}",

Ditto

---

deployment-examples/terraform/AWS/scripts/cas.json line 57 at r2 (raw file):

                  // to distinguish each shard based on the key.
                  "s3_store": {
                    "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/cas.json line 58 at r2 (raw file):

                  "s3_store": {
                    "region": "${nativelink_AWS_REGION:-us-east-1}",
                    "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/cas.json line 83 at r2 (raw file):

                      "memory": {
                        "eviction_policy": {
                          "max_bytes": "${nativelink_CAS_CONTENT_LIMIT:-1000000000}",

Ditto

---

deployment-examples/terraform/AWS/scripts/cas.json line 93 at r2 (raw file):

                      // to distinguish each shard based on the key.
                      "s3_store": {
                        "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/cas.json line 94 at r2 (raw file):

                      "s3_store": {
                        "region": "${nativelink_AWS_REGION:-us-east-1}",
                        "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 13 at r2 (raw file):

              "memory": {
                "eviction_policy": {
                  "max_bytes": "${nativelink_AC_CONTENT_LIMIT:-100000000}",

Fix screaming snake case

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 23 at r2 (raw file):

              // to distinguish each shard based on the key.
              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 24 at r2 (raw file):

              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",
                "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 45 at r2 (raw file):

              "memory": {
                "eviction_policy": {
                  "max_bytes": "${nativelink_CAS_INDEX_CACHE_LIMIT:-100000000}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 55 at r2 (raw file):

              // to distinguish each shard based on the key.
              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 56 at r2 (raw file):

              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",
                "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 81 at r2 (raw file):

                  "memory": {
                    "eviction_policy": {
                      "max_bytes": "${nativelink_CAS_CONTENT_LIMIT:-1000000000}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 91 at r2 (raw file):

                  // to distinguish each shard based on the key.
                  "s3_store": {
                    "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/scheduler.json line 92 at r2 (raw file):

                  "s3_store": {
                    "region": "${nativelink_AWS_REGION:-us-east-1}",
                    "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/worker.json line 14 at r2 (raw file):

          // to distinguish each shard based on the key.
          "s3_store": {
            "region": "${nativelink_AWS_REGION:-us-east-1}",

Fix screaming snake case

---

deployment-examples/terraform/AWS/scripts/worker.json line 15 at r2 (raw file):

          "s3_store": {
            "region": "${nativelink_AWS_REGION:-us-east-1}",
            "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/worker.json line 46 at r2 (raw file):

              // to distinguish each shard based on the key.
              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/worker.json line 47 at r2 (raw file):

              "s3_store": {
                "region": "${nativelink_AWS_REGION:-us-east-1}",
                "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/AWS/scripts/worker.json line 68 at r2 (raw file):

                  // to distinguish each shard based on the key.
                  "s3_store": {
                    "region": "${nativelink_AWS_REGION:-us-east-1}",

Ditto

---

deployment-examples/terraform/AWS/scripts/worker.json line 69 at r2 (raw file):

                  "s3_store": {
                    "region": "${nativelink_AWS_REGION:-us-east-1}",
                    "bucket": "${nativelink_AWS_S3_CAS_BUCKET:-not_set}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/browser_proxy.json line 7 at r2 (raw file):

        "backend": {
          "s3_store": {
            "region": "${nativelink_AC_S3_BUCKET_REGION:-}",

Fix screaming snake case

---

deployment-examples/terraform/GCP/module/scripts/browser_proxy.json line 8 at r2 (raw file):

          "s3_store": {
            "region": "${nativelink_AC_S3_BUCKET_REGION:-}",
            "bucket": "${nativelink_AC_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/browser_proxy.json line 25 at r2 (raw file):

        "backend": {
          "s3_store": {
            "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/browser_proxy.json line 26 at r2 (raw file):

          "s3_store": {
            "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",
            "bucket": "${nativelink_CAS_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 10 at r2 (raw file):

              "memory": {
                "eviction_policy": {
                  "max_bytes": "${nativelink_AC_MEMORY_CONTENT_LIMIT:-100000000}"

Fix screaming snake case

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 16 at r2 (raw file):

            "slow": {
              "s3_store": {
                "region": "${nativelink_AC_S3_BUCKET_REGION:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 17 at r2 (raw file):

              "s3_store": {
                "region": "${nativelink_AC_S3_BUCKET_REGION:-}",
                "bucket": "${nativelink_AC_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 45 at r2 (raw file):

                      "memory": {
                        "eviction_policy": {
                          "max_bytes": "${nativelink_CAS_MEMORY_CONTENT_LIMIT:-100000000}"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 56 at r2 (raw file):

                "slow": {
                  "s3_store": {
                    "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 57 at r2 (raw file):

                  "s3_store": {
                    "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",
                    "bucket": "${nativelink_CAS_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 82 at r2 (raw file):

    "listen_address": "0.0.0.0:50051",
    "tls": {
      "cert_file": "${nativelink_CERT_FILE:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/cas.json line 83 at r2 (raw file):

    "tls": {
      "cert_file": "${nativelink_CERT_FILE:-}",
      "key_file": "${nativelink_KEY_FILE:-}"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 8 at r2 (raw file):

          "memory": {
            "eviction_policy": {
              "max_bytes": "${nativelink_AC_MEMORY_CONTENT_LIMIT:-100000000}"

Fix screaming snake case

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 16 at r2 (raw file):

            "backend": {
              "s3_store": {
                "region": "${nativelink_AC_S3_BUCKET_REGION:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 17 at r2 (raw file):

              "s3_store": {
                "region": "${nativelink_AC_S3_BUCKET_REGION:-}",
                "bucket": "${nativelink_AC_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 43 at r2 (raw file):

                  "memory": {
                    "eviction_policy": {
                      "max_bytes": "${nativelink_CAS_MEMORY_CONTENT_LIMIT:-100000000}"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 56 at r2 (raw file):

                "backend": {
                  "s3_store": {
                    "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 57 at r2 (raw file):

                  "s3_store": {
                    "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",
                    "bucket": "${nativelink_CAS_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 91 at r2 (raw file):

    "listen_address": "0.0.0.0:50051",
    "tls": {
      "cert_file": "${nativelink_CERT_FILE:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/scheduler.json line 92 at r2 (raw file):

    "tls": {
      "cert_file": "${nativelink_CERT_FILE:-}",
      "key_file": "${nativelink_KEY_FILE:-}"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 7 at r2 (raw file):

        "backend": {
          "s3_store": {
            "region": "${nativelink_AC_S3_BUCKET_REGION:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 8 at r2 (raw file):

          "s3_store": {
            "region": "${nativelink_AC_S3_BUCKET_REGION:-}",
            "bucket": "${nativelink_AC_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 25 at r2 (raw file):

        "backend": {
          "s3_store": {
            "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 26 at r2 (raw file):

          "s3_store": {
            "region": "${nativelink_CAS_S3_BUCKET_REGION:-}",
            "bucket": "${nativelink_CAS_S3_BUCKET:-}",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 46 at r2 (raw file):

            "temp_path": "/worker/cas/temp",
            "eviction_policy": {
              "max_bytes": "${nativelink_CAS_FS_CONTENT_LIMIT:-100000000}"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 69 at r2 (raw file):

    "local": {
      "worker_api_endpoint": {
        "uri": "grpc://${nativelink_SCHEDULER_ENDPOINT:-127.0.0.1}:50061"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 75 at r2 (raw file):

        "ac_store": "AC_STORE",
        "historical_results_store": "S3_CAS_STORE",
        "success_message_template": "https://${nativelink_BROWSER_ENDPOINT:-example.com}/main/blobs/{digest_function}/action/{action_digest_hash}-{action_digest_size}/",

Ditto

---

deployment-examples/terraform/GCP/module/scripts/worker.json line 76 at r2 (raw file):

        "historical_results_store": "S3_CAS_STORE",
        "success_message_template": "https://${nativelink_BROWSER_ENDPOINT:-example.com}/main/blobs/{digest_function}/action/{action_digest_hash}-{action_digest_size}/",
        "failure_message_template": "https://${nativelink_BROWSER_ENDPOINT:-example.com}/main/blobs/{digest_function}/historical_execute_response/{historical_results_hash}-{historical_results_size}/"

Ditto

---

src/bin/cas.rs line 67 at r2 (raw file):

/// Name of environment variable to disable metrics.
const METRICS_DISABLE_ENV: &str = "nativelink_DISABLE_METRICS";

Fix screaming snake case

---

src/bin/cas.rs line 72 at r2 (raw file):

#[derive(Parser, Debug)]
#[clap(
    author = "Trace Machina, Inc. <nativelink@tracemachina.com>",

Nit: Is this email valid? Should be changed here either way just wanted to note

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 34 at r2 (raw file):

# These environmental variables are used inside the json file resolution.
export nativelink_AWS_REGION="$AWS_REGION"

Fix screaming snake case

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 35 at r2 (raw file):

# These environmental variables are used inside the json file resolution.
export nativelink_AWS_REGION="$AWS_REGION"
export nativelink_AWS_S3_CAS_BUCKET=$(echo "$TAGS"| jq -r '.Tags[] | select(.Key == "nativelink:s3_cas_bucket").Value')

Ditto

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 46 at r2 (raw file):

elif [ "$TYPE" == "cas" ]; then
    # 10% goes to action cache.
    export nativelink_AC_CONTENT_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 10 ))

Ditto

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 48 at r2 (raw file):

    export nativelink_AC_CONTENT_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 10 ))
    # 5% goes to the index memory cache.
    export nativelink_CAS_INDEX_CACHE_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 20 ))

Ditto

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 50 at r2 (raw file):

    export nativelink_CAS_INDEX_CACHE_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 20 ))
    # 85% goes to the content memory cache.
    export nativelink_CAS_CONTENT_LIMIT=$(( $TOTAL_AVAIL_MEMORY - $nativelink_AC_CONTENT_LIMIT - $nativelink_CAS_INDEX_CACHE_LIMIT ))

Ditto

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 55 at r2 (raw file):

elif [ "$TYPE" == "scheduler" ]; then
    # 10% goes to action cache.
    export nativelink_AC_CONTENT_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 10 ))

Ditto

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 57 at r2 (raw file):

    export nativelink_AC_CONTENT_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 10 ))
    # 5% goes to the index memory cache.
    export nativelink_CAS_INDEX_CACHE_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 20 ))

Ditto

---

deployment-examples/terraform/AWS/scripts/start_nativelink.sh line 59 at r2 (raw file):

    export nativelink_CAS_INDEX_CACHE_LIMIT=$(( $TOTAL_AVAIL_MEMORY / 20 ))
    # 85% goes to the content memory cache.
    export nativelink_CAS_CONTENT_LIMIT=$(( $TOTAL_AVAIL_MEMORY - $nativelink_AC_CONTENT_LIMIT - $nativelink_CAS_INDEX_CACHE_LIMIT ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 25 at r2 (raw file):

function make_certs_and_export_envs() {
    openssl req -nodes -x509 -sha256 -newkey rsa:2048 -keyout /root/key.pem -out /root/cert.pem -days 356 -subj '/CN=localhost'
    nativelink_CERT_FILE=/root/cert.pem

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 26 at r2 (raw file):

    openssl req -nodes -x509 -sha256 -newkey rsa:2048 -keyout /root/key.pem -out /root/cert.pem -days 356 -subj '/CN=localhost'
    nativelink_CERT_FILE=/root/cert.pem
    nativelink_KEY_FILE=/root/key.pem

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 27 at r2 (raw file):

    nativelink_CERT_FILE=/root/cert.pem
    nativelink_KEY_FILE=/root/key.pem
    export nativelink_CERT_FILE

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 28 at r2 (raw file):

    nativelink_KEY_FILE=/root/key.pem
    export nativelink_CERT_FILE
    export nativelink_KEY_FILE

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 37 at r2 (raw file):

    AWS_SECRET_ACCESS_KEY="$(echo "$AWS_JOINED_KEYS" | cut -d ":" -f 2)"
    cas_s3_bucket_pair=$(curl http://metadata.google.internal/computeMetadata/v1/instance/attributes/nativelink-cas-bucket -H "Metadata-Flavor: Google")
    nativelink_CAS_S3_BUCKET="$(echo "$cas_s3_bucket_pair" | cut -d ":" -f 1)"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 38 at r2 (raw file):

    cas_s3_bucket_pair=$(curl http://metadata.google.internal/computeMetadata/v1/instance/attributes/nativelink-cas-bucket -H "Metadata-Flavor: Google")
    nativelink_CAS_S3_BUCKET="$(echo "$cas_s3_bucket_pair" | cut -d ":" -f 1)"
    nativelink_CAS_S3_BUCKET_REGION="$(echo "$cas_s3_bucket_pair" | cut -d ":" -f 2)"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 40 at r2 (raw file):

    nativelink_CAS_S3_BUCKET_REGION="$(echo "$cas_s3_bucket_pair" | cut -d ":" -f 2)"
    ac_s3_bucket_pair=$(curl http://metadata.google.internal/computeMetadata/v1/instance/attributes/nativelink-ac-bucket -H "Metadata-Flavor: Google")
    nativelink_AC_S3_BUCKET="$(echo "$ac_s3_bucket_pair" | cut -d ":" -f 1)"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 41 at r2 (raw file):

    ac_s3_bucket_pair=$(curl http://metadata.google.internal/computeMetadata/v1/instance/attributes/nativelink-ac-bucket -H "Metadata-Flavor: Google")
    nativelink_AC_S3_BUCKET="$(echo "$ac_s3_bucket_pair" | cut -d ":" -f 1)"
    nativelink_AC_S3_BUCKET_REGION="$(echo "$ac_s3_bucket_pair" | cut -d ":" -f 2)"

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 47 at r2 (raw file):

    export AWS_ACCESS_KEY_ID
    export AWS_SECRET_ACCESS_KEY
    export nativelink_CAS_S3_BUCKET

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 48 at r2 (raw file):

    export AWS_SECRET_ACCESS_KEY
    export nativelink_CAS_S3_BUCKET
    export nativelink_CAS_S3_BUCKET_REGION

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 49 at r2 (raw file):

    export nativelink_CAS_S3_BUCKET
    export nativelink_CAS_S3_BUCKET_REGION
    export nativelink_AC_S3_BUCKET

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 50 at r2 (raw file):

    export nativelink_CAS_S3_BUCKET_REGION
    export nativelink_AC_S3_BUCKET
    export nativelink_AC_S3_BUCKET_REGION

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 93 at r2 (raw file):

    # 10% goes to AC.
    nativelink_AC_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory / 10 ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 94 at r2 (raw file):

    # 10% goes to AC.
    nativelink_AC_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory / 10 ))
    nativelink_AC_FS_CONTENT_LIMIT=$(( $total_avail_disk_size / 10 ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 96 at r2 (raw file):

    nativelink_AC_FS_CONTENT_LIMIT=$(( $total_avail_disk_size / 10 ))
    # Remaining goes to CAS.
    nativelink_CAS_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory - $nativelink_AC_MEMORY_CONTENT_LIMIT ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 97 at r2 (raw file):

    # Remaining goes to CAS.
    nativelink_CAS_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory - $nativelink_AC_MEMORY_CONTENT_LIMIT ))
    nativelink_CAS_FS_CONTENT_LIMIT=$(( $total_avail_disk_size - $nativelink_AC_FS_CONTENT_LIMIT ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 99 at r2 (raw file):

    nativelink_CAS_FS_CONTENT_LIMIT=$(( $total_avail_disk_size - $nativelink_AC_FS_CONTENT_LIMIT ))

    export nativelink_AC_MEMORY_CONTENT_LIMIT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 100 at r2 (raw file):

    export nativelink_AC_MEMORY_CONTENT_LIMIT
    export nativelink_AC_FS_CONTENT_LIMIT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 101 at r2 (raw file):

    export nativelink_AC_MEMORY_CONTENT_LIMIT
    export nativelink_AC_FS_CONTENT_LIMIT
    export nativelink_CAS_MEMORY_CONTENT_LIMIT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 102 at r2 (raw file):

    export nativelink_AC_FS_CONTENT_LIMIT
    export nativelink_CAS_MEMORY_CONTENT_LIMIT
    export nativelink_CAS_FS_CONTENT_LIMIT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 114 at r2 (raw file):

    # 10% goes to AC.
    nativelink_AC_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory / 10 ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 116 at r2 (raw file):

    nativelink_AC_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory / 10 ))
    # Remaining goes to CAS.
    nativelink_CAS_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory - $nativelink_AC_MEMORY_CONTENT_LIMIT ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 118 at r2 (raw file):

    nativelink_CAS_MEMORY_CONTENT_LIMIT=$(( $total_avail_memory - $nativelink_AC_MEMORY_CONTENT_LIMIT ))

    export nativelink_AC_MEMORY_CONTENT_LIMIT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 119 at r2 (raw file):

    export nativelink_AC_MEMORY_CONTENT_LIMIT
    export nativelink_CAS_MEMORY_CONTENT_LIMIT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 125 at r2 (raw file):

    setup_s3_envs

    nativelink_SCHEDULER_ENDPOINT=$(curl http://metadata.google.internal/computeMetadata/v1/instance/attributes/nativelink-internal-worker-scheduler-endpoint -H "Metadata-Flavor: Google")

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 126 at r2 (raw file):

    nativelink_SCHEDULER_ENDPOINT=$(curl http://metadata.google.internal/computeMetadata/v1/instance/attributes/nativelink-internal-worker-scheduler-endpoint -H "Metadata-Flavor: Google")
    nativelink_BROWSER_ENDPOINT=$(curl http://metadata.google.internal/computeMetadata/v1/instance/attributes/nativelink-browser-endpoint -H "Metadata-Flavor: Google")

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 131 at r2 (raw file):

    # We don't cache AC on workers, so ~71% goes to CAS. To leave room for jobs to use disk space too.
    nativelink_CAS_FS_CONTENT_LIMIT=$(( ${total_disk_size:-0} * 10 / 15 ))

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 133 at r2 (raw file):

    nativelink_CAS_FS_CONTENT_LIMIT=$(( ${total_disk_size:-0} * 10 / 15 ))

    export nativelink_SCHEDULER_ENDPOINT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 134 at r2 (raw file):

    export nativelink_SCHEDULER_ENDPOINT
    export nativelink_BROWSER_ENDPOINT

Ditto

---

deployment-examples/terraform/GCP/module/scripts/start_nativelink.sh line 135 at r2 (raw file):

    export nativelink_SCHEDULER_ENDPOINT
    export nativelink_BROWSER_ENDPOINT
    export nativelink_CAS_FS_CONTENT_LIMIT

Ditto

---

nativelink-config/src/cas_server.rs line 556 at r2 (raw file):

    /// overhead of collecting metrics is very low, so this flag should only be
    /// used if there is a very good reason to disable metrics.
    /// This flag can be forcably set using the `nativelink_DISABLE_METRICS` variable.

Fix screaming snake case

[MarcusSorealheis]

I think I fixed all these errors but Reviewable does not update outdated files.

Reviewable status: 152 of 166 files reviewed, 103 unresolved discussions (waiting on @aaronmondal, @allada, and @blakehatch)

[aaronmondal]

Reviewed 149 of 166 files at r1, 3 of 3 files at r2, 14 of 14 files at r3, all commit messages.
Reviewable status: all files reviewed, 103 unresolved discussions (waiting on @allada, @blakehatch, and @MarcusSorealheis)

[aaronmondal]

Since cache is failing, you can try to disable/remove these lines:

nativelink/.github/workflows/image.yaml

Lines 31 to 33 in d264624

	- name: Cache Nix derivations
	uses: >- # Custom commit, last pinned at 2023-11-17.
	DeterminateSystems/magic-nix-cache-action@a04e6275a6bea232cd04fc6f3cbf20d4cb02a3e1

[blakehatch]

Yup all SSC cases look to be fixed, also reviewable did seem to screw something up with the files will have to look into that.

Reviewed all commit messages.
Reviewable status: all files reviewed, 103 unresolved discussions (waiting on @adam-singer, @allada, and @MarcusSorealheis)