Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Mark prometheus config as experimental #473

Merged
merged 1 commit into from Dec 12, 2023

Conversation

allada
Copy link
Collaborator

@allada allada commented Dec 12, 2023

Since prometheus has known issues, in prep for the release, we are flagging this config as experimental until we can fix the bugs.


This change is Reviewable

Since prometheus has known issues, in prep for the release, we are
flagging this config as experimental until we can fix the bugs.
Copy link
Collaborator Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@adam-singer

Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @adam-singer)

Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 9 files reviewed, all discussions resolved

Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @allada)

Copy link
Collaborator Author

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: @chrisstaite-menlo

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @allada)

@allada allada merged commit 931e721 into main Dec 12, 2023
20 of 21 checks passed
@allada allada deleted the mark-prometheus-experimental branch December 12, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants