Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the long command example for Windows Powershell in documentat… #501

Merged
merged 1 commit into from Dec 18, 2023

Conversation

steedmicro
Copy link
Contributor

@steedmicro steedmicro commented Dec 18, 2023

Description

On Ubuntu and MacOS, they use "" character for line truncations of a long command.
But the problem is that on Windows, we use "^" character for line truncations on Command Prompt Tool and "`" character on Powershell Tool. Most users like to copy the whole lines of command without editing when they first approach this project.
More detailed description can be found in the issue below.

Fixes #500

Type of change

  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Collaborator

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @steed924)

Copy link
Contributor

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @steed924)

@aaronmondal aaronmondal merged commit 0536d8e into TraceMachina:main Dec 18, 2023
18 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the long command example for Windows Powershell in documentation files
3 participants