Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Fixed-Buffer Dependency #509

Merged
merged 1 commit into from Dec 19, 2023
Merged

Remove Fixed-Buffer Dependency #509

merged 1 commit into from Dec 19, 2023
+61 −692

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Dec 19, 2023 •
edited by allada

Description

Remove the Fixed-Buffer dependency. It is no longer used.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@MarcusSorealheis MarcusSorealheis force-pushed the remove-unused-deps branch 3 times, most recently from 38b8a81 to dd9d91e Compare December 19, 2023 18:15
allada
allada approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)

aaronmondal
aaronmondal approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)

@aaronmondal aaronmondal merged commit 5a6b182 into TraceMachina:main Dec 19, 2023
11 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allada allada allada approved these changes

@aaronmondal aaronmondal aaronmondal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcusSorealheis @allada @aaronmondal