Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bazel run command documentation #590

Merged

Conversation

steedmicro
Copy link
Contributor

@steedmicro steedmicro commented Jan 4, 2024

Description

The bazel run command listed in the README.md file doesn't work.
I applied @aaronmondal 's recommendation for this PR and tested it works fine.
Detailed discussion can be found in the issue link below.

Fixes #582

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nativelink-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 1:00pm

@steedmicro
Copy link
Contributor Author

cc: @allada , @MarcusSorealheis , @aaronmondal . Thanks.

@MarcusSorealheis
Copy link
Collaborator

@blakehatch the docs say they are updated, but that's because this workflow runs for every PR. Ideally, the GitHub action only runs when affected code is changed.

Also, @blakehatch and @steed924 is there a simple and consistent way to pull the README content into the docs? This needs that change.

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes should be in nativelink-docs as well

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@MarcusSorealheis MarcusSorealheis merged commit 7f4a007 into TraceMachina:main Jan 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel run doesn't work on local machine - Ubuntu 22.0.4
2 participants