Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode accessibility contrast and make theme dynamic #597

Merged

Conversation

blakehatch
Copy link
Contributor

@blakehatch blakehatch commented Jan 8, 2024

Description

Fixes default theme selection so it is based off user preferences and also corrects the contrast to be more accessible as seen below.

Untitled 5

Fixes #591


This change is Reviewable

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nativelink-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 4:50pm

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@blakehatch blakehatch merged commit d5443c8 into TraceMachina:main Jan 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode in docs is not accessible
2 participants