Add artifact warning to documentation and swap out cargo emoji #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
blakehatch
force-pushed
the
quickstart-warnings
branch
from
20e684e
to
9d64533
Compare
MarcusSorealheis
approved these changes
Jan 8, 2024
MarcusSorealheis
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: pre-commit-checks
blakehatch
force-pushed
the
quickstart-warnings
branch
from
9d64533
to
f83b457
Compare
adam-singer
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
tioli: --expunge or --expunge_async, flag sends clean to a background task thus returns the shell quicker. I do wonder if suggesting expunge should generally be done, but any basic/power user of bazel will probably decide that on their own.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and pending CI: Cargo Dev / ubuntu-22.04, Vercel, asan / ubuntu-22.04, pre-commit-checks, publish-image
blakehatch
force-pushed
the
quickstart-warnings
branch
from
f83b457
to
4cf32a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warnings to README and documentation for users building from source and updated cargo emoji.
Fixes #592
Type of change
Please delete options that are not relevant.
Checklist
This change is