Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent untested commits from being mergeable #612

Closed
aaronmondal opened this issue Jan 17, 2024 · 1 comment
Closed

Prevent untested commits from being mergeable #612

aaronmondal opened this issue Jan 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working security Issues that have security implications

Comments

@aaronmondal
Copy link
Contributor

aaronmondal commented Jan 17, 2024

When a new contributor creates a PR, the testsuite isn't run unless a maintainer enables it.

If such a PR gets an LGTM before enabling the testsuite it creates a situation where the PR is treated as "green" and can be merged without running any tests.

This is flagged as violation of https://github.com/ossf/scorecard/blob/main/docs/checks.md#ci-tests

Example:

@aaronmondal aaronmondal added bug Something isn't working security Issues that have security implications labels Jan 17, 2024
@aaronmondal
Copy link
Contributor Author

Fixed. It's now required to run the pre-commit-checks before working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security Issues that have security implications
Projects
None yet
Development

No branches or pull requests

2 participants