Helpful Error Output for Integration Test #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please note, it doesn't really fix 624. I'm still tracking down all the places where we could do work like this and still need to determine if it's a good idea to do so. |
MarcusSorealheis
force-pushed
the
example-guiding-error-output
branch
from
86f1f26
to
0728e17
Compare
adam-singer
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @aaronmondal)
adam-singer
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @aaronmondal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Throughout the codebase, there are a number of scripts that either need to be invoked or are invoked automatically on the user's behalf. We need to reduce the friction associated with a number of these errors as they are somewhat opaque.
Fixes #624
Type of change
Developer Experience
Please delete options that are not relevant.
How Has This Been Tested?
Both shell scripts and integration tests are notoriously difficult to test so I have not put much thought into it. Maybe we will be there in the future and can revisit.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is