Reenable caching for nix workflows #631
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aaronmondal
force-pushed
the
reenable-nix-caching
branch
from
9164bd6
to
00af085
Compare
aaronmondal
force-pushed
the
reenable-nix-caching
branch
from
00af085
to
8ee4ad9
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
.github/workflows/image.yaml line 30 at r1 (raw file):
with: github-token: ${{ secrets.GITHUB_TOKEN }} # TODO(aaronmondal): Remove after:
I am seeing this comment a few places but this PR was recently merged. As a result, should we remove it? I wasn't sure what was meant by the comment. Should this section be removed since 820 was merged or does it get skipped after, which is now, since it was just merged?
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 1 of 1 LGTMs obtained
aaronmondal
force-pushed
the
reenable-nix-caching
branch
from
8ee4ad9
to
434d404
Compare
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained
The previous crashes have been fixed in Nix 2.19.3. Thix commit also includes missing `github-token` fields which increase the API rate limit. Fixes: TraceMachina#464
aaronmondal
force-pushed
the
reenable-nix-caching
branch
from
434d404
to
b33a8c5
Compare
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained
There was a problem hiding this comment.
Reviewable status: 2 of 1 LGTMs obtained
.github/workflows/image.yaml line 30 at r1 (raw file):
Previously, MarcusSorealheis (Marcus Eagan) wrote…
I am seeing this comment a few places but this PR was recently merged. As a result, should we remove it? I wasn't sure what was meant by the comment. Should this section be removed since 820 was merged or does it get skipped after, which is now, since it was just merged?
Done.
There was a problem hiding this comment.
My bad. Added reviewers in the wrong way.
+@MarcusSorealheis +@adam-singer +@allada
Reviewable status: 2 of 3 LGTMs obtained (waiting on @adam-singer)
There was a problem hiding this comment.
Dismissed @MarcusSorealheis from a discussion.
Reviewable status:complete! 1 of 1 LGTMs obtained
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
This has been fixed upstream. Pull the change in early to speed up
workflows significantly. This also includes missing
github-tokenfields which increase the API rate limit.
Fixes: #464
Type of change
This change is