Retry GrpcStore get_part_ref #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
If a read request fails, it is retried in GrpcStore::read, however if a stream breaks while it's being read from then it is not retried. Therefore, break the read retry logic from the get_part_ref retry logic to allow a read to resume from where it left off.
chrisstaite-menlo
force-pushed
the
grpc_store_retry_write
branch
from
fc6f68b
to
28f2bb5
Compare
allada
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
@adam-singer, We really need to figure out a good solution to test Grpc store stuff.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
adam-singer
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a read request fails, it is retried in GrpcStore::read, however if a stream
breaks while it's being read from then it is not retried. Therefore, break
the read retry logic from the get_part_ref retry logic to allow a read to
resume from where it left off.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested in local cluster.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is