Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to compression and existence cache store #651

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

blakehatch
Copy link
Contributor

@blakehatch blakehatch commented Feb 1, 2024

Description

Adds metrics for existence cache store and compression store.

Fixes #647

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nativelink-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2024 3:25am

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained


nativelink-store/src/compression_store.rs line 199 at r1 (raw file):

}

impl MetricsComponent for UploadState {

nit: This is not used or bound anywhere.

UploadState is a temporary state for each upload payload not a global.

Copy link
Contributor Author

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Local / ubuntu-22.04, Vercel, integration-tests (20.04), pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04


nativelink-store/src/compression_store.rs line 199 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

nit: This is not used or bound anywhere.

UploadState is a temporary state for each upload payload not a global.

Done.

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@blakehatch blakehatch merged commit 722c80b into TraceMachina:main Feb 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Metrics to Existence Cache and Compression Store
2 participants