Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust all instances of 'Native Link' in comments and metadata to 'NativeLink' #658

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

blakehatch
Copy link
Contributor

@blakehatch blakehatch commented Feb 7, 2024

Description

Adjusted naming and assured that all instances are just in documentation and metadata so as to not introduce any breakage when adjusting. Was done carefully per-file and not just a global find & replace.


This change is Reviewable

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nativelink-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 3:50pm

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 178 of 178 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: macos-13

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capital L

Copy link
Contributor

@tyr-one tyr-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One lowercase L made it through, otherwise looks all good!

Copy link
Contributor Author

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good catch!

Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Local / ubuntu-22.04, Vercel, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04


nativelink-docs/docs/About.mdx line 0 at r1 (raw file):

Previously, tyr-one wrote…

capital L

Done.

Copy link
Contributor

@tyr-one tyr-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: macos-13

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained

blakehatch

This comment was marked as off-topic.

@blakehatch blakehatch merged commit 4e7d68b into TraceMachina:main Feb 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants