Add API so stores can get Arc<Store> or &Store #679
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, Vercel, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @chrisstaite-menlo)
A little bit of cleanup to remove the need have an Arc<Store> when a user wants to up/down-cast to another store. Users can now do this by reference if they don't have an Arc<Store>.
There was a problem hiding this comment.
Reviewed 22 of 24 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @chrisstaite-menlo)
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @chrisstaite-menlo)
nativelink-store/src/completeness_checking_store.rs line 361 at r1 (raw file):
} fn as_any(self: Arc<Self>) -> Box<dyn std::any::Any + Send> {
yay! finally got rid of this insanely dumb heap allocation.
)" This reverts commit 5df8a78. This appears to increase build size unnaturally.
)" This reverts commit 5df8a78. This appears to increase build size unnaturally, crashing CI.
A little bit of cleanup to remove the need have an Arc when a user wants to up/down-cast to another store. Users can now do this by reference if they don't have an Arc.
This change is