Draw a General Purpose Diagram #705
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MarcusSorealheis
force-pushed
the
docs/diagram
branch
from
fefbf4b
to
2ae1ec5
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
README.md line 83 at r1 (raw file):
build server (client)->>scheduler pool: queue jobs scheduler pool->>worker pool: route jobs worker pool->>cas: compute digests
nit: Don't say compute digests say upload results or upload artifacts or something.
README.md line 86 at r1 (raw file):
worker pool->>scheduler pool: result download instructions scheduler pool->>build server (client): result download instructions cas->>build server (client): service queries
This arrow needs to be pointed from client -> cas as well.
MarcusSorealheis
force-pushed
the
docs/diagram
branch
from
2ae1ec5
to
67621e7
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
README.md line 86 at r1 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
This arrow needs to be pointed from
client -> casas well.
Is it possible to do this as an arrow directly from build server to cas and vice-versa? It's not very clear what dashed line means here.
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
README.md line 86 at r1 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
Is it possible to do this as an arrow directly from
build servertocasand vice-versa? It's not very clear what dashed line means here.
I suggest having two lines, one from build server -> cas and another build server <- cas one with the request and the other with the response.
MarcusSorealheis
force-pushed
the
docs/diagram
branch
from
67621e7
to
fb1cf7b
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04
README.md line 86 at r1 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
I suggest having two lines, one from
build server -> casand anotherbuild server <- casone with the request and the other with the response.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04
Description
This diagram is a general purpose diagram for describing NativeLink to people new to the project and looking to understand it conceptually.
Type of change
Documentation
This change is