Optimize file uploads when source is file #723
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @adam-singer and @zbirenbaum)
When using nativelink with a local worker/CAS setup, adds optimizations which make it faster to upload files from the worker to the CAS. This is specifically useful for Buck2 for users that want to build hermetically. closes: TraceMachina#409
There was a problem hiding this comment.
Does feel a bit linear in terms of how optimization is applied via single function/single enum, since its specialized on store and enums can be defined in a combination of names it is probably fine.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @zbirenbaum)
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained
When using nativelink with a local worker/CAS setup, adds optimizations which make it faster to upload files from the worker to the CAS.
This is specifically useful for Buck2 for users that want to build hermetically.
closes: #409
This change is