Completeness checking store should not check if directory digests exist

[allada]

REv2 does not require clients to upload directory digests. Instead they are only required to upload the tree root which has all the directories in it.

closes #747

---

This change is 

[allada]

Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04

a discussion (no related file):
Needs tests

---

[allada]

+@aaronmondal
+@zbirenbaum

Fyi: @blakehatch

Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), integration-tests (20.04), macos-13, pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale (waiting on @aaronmondal and @zbirenbaum)

[MarcusSorealheis]

Reviewable status: 0 of 2 LGTMs obtained (waiting on @aaronmondal and @zbirenbaum)

---

nativelink-store/src/completeness_checking_store.rs line 93 at r2 (raw file):

                .into_iter()
                .chain(tree.root)
                .flat_map(|dir| dir.files.into_iter().filter_map(|f| f.digest.map(DigestInfo::try_from)));

nit: to make this a bit more readable, consider breaking this up into a few lines:

.flat_map(|dir| {
    dir.files
        .par_iter()
        .filter_map(|f| f.digest.map(DigestInfo::try_from))
})

sometimes it can go either way but the.filter_map is a good candidate for being on its own line.

[adam-singer]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @aaronmondal and @zbirenbaum)

[allada]

Reviewable status: 0 of 2 LGTMs obtained (waiting on @aaronmondal and @zbirenbaum)

---

nativelink-store/src/completeness_checking_store.rs line 93 at r2 (raw file):

Previously, MarcusSorealheis (Marcus Eagan) wrote…

nit: to make this a bit more readable, consider breaking this up into a few lines:

.flat_map(|dir| {
    dir.files
        .par_iter()
        .filter_map(|f| f.digest.map(DigestInfo::try_from))
})

sometimes it can go either way but the.filter_map is a good candidate for being on its own line.

Sadly it was like you showed but our linter forced it this way. I can use a comment trick to force it into this format, but I would prefer to not have this copied elsewhere.

There's not much I can do here, even temporary variables won't work because it will require it to be a lambda/function... and that would make the code worse imo.

[aaronmondal]

Reviewed all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @zbirenbaum)

[zbirenbaum]

Reviewable status: 2 of 2 LGTMs obtained

[blakehatch]

that change makes this section of the code so much simpler 🫠

Reviewable status: 2 of 2 LGTMs obtained

[MarcusSorealheis]

Reviewable status: 2 of 2 LGTMs obtained