Unbreak CI #769
Unbreak CI #769
Conversation
There was a problem hiding this comment.
+@MarcusSorealheis +@blakehatch +@adam-singer +@allada
Reviewable status: 0 of 4 LGTMs obtained (waiting on @adam-singer, @allada, @blakehatch, and @MarcusSorealheis)
.github/workflows/nix.yaml
Outdated
| with: | ||
| path: "~/.cache/bazel" | ||
| key: ${{ runner.os }}-bazel-nix | ||
| # TODO(aaronmondal): Somehow this cache breaks CI. |
There was a problem hiding this comment.
This is more than a formatting error. I am fine with merging this one, but we need to open a ticket for investigating why this cache broke CI.
There was a problem hiding this comment.
Reviewable status: 1 of 4 LGTMs obtained (waiting on @adam-singer, @allada, and @blakehatch)
Breakages were caused by a formatting issue and caching issues.
There was a problem hiding this comment.
Reviewable status: 1 of 4 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, publish-image, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @adam-singer, @allada, and @blakehatch)
.github/workflows/nix.yaml line 37 at r1 (raw file):
Previously, MarcusSorealheis (Marcus Eagan) wrote…
This is more than a formatting error. I am fine with merging this one, but we need to open a ticket for investigating why this cache broke CI.
Done. Agreed. Updated commit message and created issue #772
There was a problem hiding this comment.
-@allada -@blakehatch -@adam-singer
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: windows-2022 / stable
There was a problem hiding this comment.
Dismissed @MarcusSorealheis from a discussion.
Reviewable status:complete! 1 of 1 LGTMs obtained
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
Just a formatting issue.
This change is