Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect bazel version 6.4.0+ in documenation #801

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

blizzardc0der
Copy link
Contributor

@blizzardc0der blizzardc0der commented Mar 27, 2024

Description

The documentation says it supports Bazel 6.4.0+, but the project actually supports bazel 7.0.2+.
I think the documentation needs to be updated.

Here's the bazel version talking in the documenation.

* Bazel 6.4.0+

Here's the actual bazel version supported from the .bazelversion file.

Fixes #800

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • Updated documentation if needed
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@blizzardc0der
Copy link
Contributor Author

I hope you to review this. cc: @allada, @steed924 .

Copy link
Member

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! 2 of 1 LGTMs obtained

@aaronmondal aaronmondal merged commit b1b3bcb into TraceMachina:main Mar 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel 6.4.0+ in documentation not correct
3 participants