Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release NativeLink v0.3.0 #838

Merged
merged 1 commit into from Apr 9, 2024

Conversation

aaronmondal
Copy link
Contributor

@aaronmondal aaronmondal commented Apr 5, 2024

This change is Reviewable

Copy link
Contributor Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@MarcusSorealheis +@allada +@zbirenbaum +@adam-singer +@blakehatch

Please give this PR an LGTM as soon as you've landed the PRs you want in this release. I'll merge this when we have all 5 LGTMs.

Reviewable status: 0 of 5 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @adam-singer, @allada, @blakehatch, @MarcusSorealheis, and @zbirenbaum)

@aaronmondal aaronmondal marked this pull request as ready for review April 5, 2024 17:55
Copy link
Contributor Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 5 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04 (waiting on @adam-singer, @allada, @blakehatch, @MarcusSorealheis, and @zbirenbaum)

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: 0 of 5 LGTMs obtained, and pending CI: Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Remote / large-ubuntu-22.04, docker-compose-compiles-nativelink (20.04), macos-13, windows-2022 / stable (waiting on @adam-singer, @allada, @blakehatch, and @zbirenbaum)

Copy link
Collaborator

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: 0 of 5 LGTMs obtained, and 46 discussions need to be resolved (waiting on @adam-singer, @blakehatch, @MarcusSorealheis, and @zbirenbaum)


CHANGELOG.md line 10 at r1 (raw file):

### ⛰️  Features

nit: Move Breaking changes to the top.


CHANGELOG.md line 15 at r1 (raw file):

- Add configuration breakdown page ([#725](https://github.com/TraceMachina/nativelink/issues/725)) - ([35daf43](https://github.com/TraceMachina/nativelink/commit/35daf433f01150cdf3b5da4e9a97e561be03cbdf))
- Add hadolint to pre-commit hooks ([#422](https://github.com/TraceMachina/nativelink/issues/422)) - ([d8afd33](https://github.com/TraceMachina/nativelink/commit/d8afd332db15edbf4ee3078a44397b28f6beb529))
- Add API so stores can get Arc<Store> or &Store ([#679](https://github.com/TraceMachina/nativelink/issues/679)) - ([5df8a78](https://github.com/TraceMachina/nativelink/commit/5df8a780fc099e9b594f7dfd92f0ed59ffadd95c))

nit: This is a refactor.


CHANGELOG.md line 17 at r1 (raw file):

- Add API so stores can get Arc<Store> or &Store ([#679](https://github.com/TraceMachina/nativelink/issues/679)) - ([5df8a78](https://github.com/TraceMachina/nativelink/commit/5df8a780fc099e9b594f7dfd92f0ed59ffadd95c))
- Add check for slow store to be noop and conditionally replace with fast ([#670](https://github.com/TraceMachina/nativelink/issues/670)) - ([e402a10](https://github.com/TraceMachina/nativelink/commit/e402a10d113fada3f73918090b9c58521b225011))
- [Breaking] Change in behavior of /status by introduction of component based health ([#636](https://github.com/TraceMachina/nativelink/issues/636)) - ([48cadc7](https://github.com/TraceMachina/nativelink/commit/48cadc74c886b0d102a016656e6d8cda3adea0c2))

nit: Breaking.


CHANGELOG.md line 20 at r1 (raw file):

- Max concurrent GrpcStore streams ([#656](https://github.com/TraceMachina/nativelink/issues/656)) - ([7548d4b](https://github.com/TraceMachina/nativelink/commit/7548d4b58e967e665df029d1df7b79f81f9d15e2))
- Add metrics to compression and existence cache store ([#651](https://github.com/TraceMachina/nativelink/issues/651)) - ([722c80b](https://github.com/TraceMachina/nativelink/commit/722c80bc50149210f064fadb52f1ad04bf9197db))
- Re-Add Rustup to the README ([#648](https://github.com/TraceMachina/nativelink/issues/648)) - ([0cba4fa](https://github.com/TraceMachina/nativelink/commit/0cba4fa80f7583c7462c157ff60189501ab00658))

nit: This is documentation.


CHANGELOG.md line 22 at r1 (raw file):

- Re-Add Rustup to the README ([#648](https://github.com/TraceMachina/nativelink/issues/648)) - ([0cba4fa](https://github.com/TraceMachina/nativelink/commit/0cba4fa80f7583c7462c157ff60189501ab00658))
- Allow ByteStream write restart ([#635](https://github.com/TraceMachina/nativelink/issues/635)) - ([3fabbaa](https://github.com/TraceMachina/nativelink/commit/3fabbaaeb1c029ce98d979acb58b5ec94af5c3a4))
- [BREAKING] Add concurrency limit to GRPC ([#627](https://github.com/TraceMachina/nativelink/issues/627)) - ([b47f39b](https://github.com/TraceMachina/nativelink/commit/b47f39ba9951fe8de554fe2725fc16136cfe8699))

nit: Breaking.


CHANGELOG.md line 26 at r1 (raw file):

- Add support for mTLS ([#470](https://github.com/TraceMachina/nativelink/issues/470)) - ([6a379b3](https://github.com/TraceMachina/nativelink/commit/6a379b314ef3f4428f116f82d7af55e1e31ca7ac))
- Add S3 http2 toggle flag ([#604](https://github.com/TraceMachina/nativelink/issues/604)) - ([8c433cd](https://github.com/TraceMachina/nativelink/commit/8c433cdd443a2a4d420874171066b3f7d67a1790))
- Update README.md for AWS Terraform Deployment ([#608](https://github.com/TraceMachina/nativelink/issues/608)) - ([8a43fe4](https://github.com/TraceMachina/nativelink/commit/8a43fe4ab2b29a9849e6b69429e2542360118a15))

nit: This is documentation.


CHANGELOG.md line 28 at r1 (raw file):

- Update README.md for AWS Terraform Deployment ([#608](https://github.com/TraceMachina/nativelink/issues/608)) - ([8a43fe4](https://github.com/TraceMachina/nativelink/commit/8a43fe4ab2b29a9849e6b69429e2542360118a15))
- Add blake3 support for verify store ([#575](https://github.com/TraceMachina/nativelink/issues/575)) - ([3acefc7](https://github.com/TraceMachina/nativelink/commit/3acefc73d87b4091fc399dfed4951dd8046626a3))
- Add OSFamily property in basic_cas.json ([#577](https://github.com/TraceMachina/nativelink/issues/577)) - ([3578d50](https://github.com/TraceMachina/nativelink/commit/3578d50fa78387670b7d3761396e4c26b7ee8814))

nit: This is documentation.


CHANGELOG.md line 36 at r1 (raw file):

- Fix nightly clippy warnings ([#817](https://github.com/TraceMachina/nativelink/issues/817)) - ([6d87cca](https://github.com/TraceMachina/nativelink/commit/6d87cca55ef739c2253860885e53529e2084c498))
- Fix `.gitignore` after 1a43ef9 ([#797](https://github.com/TraceMachina/nativelink/issues/797)) - ([53e5a99](https://github.com/TraceMachina/nativelink/commit/53e5a99bd96491c75fce050fd290812cf47d7219))
- Fix incorrect bazel version 6.4.0+ in documenation ([#801](https://github.com/TraceMachina/nativelink/issues/801)) - ([b1b3bcb](https://github.com/TraceMachina/nativelink/commit/b1b3bcb3d5713778d60ecb13afd151b5f50d0209))

nit: Documentation.


CHANGELOG.md line 38 at r1 (raw file):

- Fix incorrect bazel version 6.4.0+ in documenation ([#801](https://github.com/TraceMachina/nativelink/issues/801)) - ([b1b3bcb](https://github.com/TraceMachina/nativelink/commit/b1b3bcb3d5713778d60ecb13afd151b5f50d0209))
- Fix image publishing workflow after 1a43ef9 ([#777](https://github.com/TraceMachina/nativelink/issues/777)) - ([54b21b8](https://github.com/TraceMachina/nativelink/commit/54b21b8512e7cf920c4c2d3e21110e7266fc7f27))
- Update flake ([#765](https://github.com/TraceMachina/nativelink/issues/765)) - ([63a01c5](https://github.com/TraceMachina/nativelink/commit/63a01c54c8315ff74681835f6f7d065892b09428))

nit: Bump versions.


CHANGELOG.md line 41 at r1 (raw file):

- Check owner and group executable bits ([#727](https://github.com/TraceMachina/nativelink/issues/727)) - ([cea2336](https://github.com/TraceMachina/nativelink/commit/cea2336c20145d36202413ec55cbe95b71bbce36))
- Fix case where resource_name not set in stream error ([#746](https://github.com/TraceMachina/nativelink/issues/746)) - ([a651f2c](https://github.com/TraceMachina/nativelink/commit/a651f2ce25238c48c5946d84105d7214fab763ce))
- Set `rust-version` ([#734](https://github.com/TraceMachina/nativelink/issues/734)) - ([d2dd46d](https://github.com/TraceMachina/nativelink/commit/d2dd46da3ae107b2902ca772b084c7231d0d71c3))

nit: Bump versions.


CHANGELOG.md line 42 at r1 (raw file):

- Fix case where resource_name not set in stream error ([#746](https://github.com/TraceMachina/nativelink/issues/746)) - ([a651f2c](https://github.com/TraceMachina/nativelink/commit/a651f2ce25238c48c5946d84105d7214fab763ce))
- Set `rust-version` ([#734](https://github.com/TraceMachina/nativelink/issues/734)) - ([d2dd46d](https://github.com/TraceMachina/nativelink/commit/d2dd46da3ae107b2902ca772b084c7231d0d71c3))
- Bump mio to v0.8.11 ([#719](https://github.com/TraceMachina/nativelink/issues/719)) - ([7169fc9](https://github.com/TraceMachina/nativelink/commit/7169fc9ccd0248330841532f66a263e505d35529))

nit: Bump versions.


CHANGELOG.md line 54 at r1 (raw file):

- Minor refactor of functionally same code ([#607](https://github.com/TraceMachina/nativelink/issues/607)) - ([51715bd](https://github.com/TraceMachina/nativelink/commit/51715bd236f46068da9c94422d9a899dcd14cd18))
- Fix a potential bug in DropCloserReadHalf::take() ([#606](https://github.com/TraceMachina/nativelink/issues/606)) - ([70e8525](https://github.com/TraceMachina/nativelink/commit/70e852598580e48d54835b6ea7d2be6ec953b7b3))
- Fix dark mode accessibility contrast and made theme dynamic based on user machine ([#597](https://github.com/TraceMachina/nativelink/issues/597)) - ([d5443c8](https://github.com/TraceMachina/nativelink/commit/d5443c85aab894d31393215d5d33f6111f3a94cc))

nit: Documentation.


CHANGELOG.md line 59 at r1 (raw file):

### 🛠️ Refactor

- Update docusaurus monorepo to v3.2.1 ([#821](https://github.com/TraceMachina/nativelink/issues/821)) - ([d640321](https://github.com/TraceMachina/nativelink/commit/d640321138d7b7e1473347181d29a7fd70068e1e))

nit: Bump versions.


CHANGELOG.md line 60 at r1 (raw file):

- Update docusaurus monorepo to v3.2.1 ([#821](https://github.com/TraceMachina/nativelink/issues/821)) - ([d640321](https://github.com/TraceMachina/nativelink/commit/d640321138d7b7e1473347181d29a7fd70068e1e))
- Update Configuration.mdx ([#822](https://github.com/TraceMachina/nativelink/issues/822)) - ([15b455c](https://github.com/TraceMachina/nativelink/commit/15b455c1d7797dcf575aaa57e10e0736cd409877))

nit: Documentation.


CHANGELOG.md line 61 at r1 (raw file):

- Update docusaurus monorepo to v3.2.1 ([#821](https://github.com/TraceMachina/nativelink/issues/821)) - ([d640321](https://github.com/TraceMachina/nativelink/commit/d640321138d7b7e1473347181d29a7fd70068e1e))
- Update Configuration.mdx ([#822](https://github.com/TraceMachina/nativelink/issues/822)) - ([15b455c](https://github.com/TraceMachina/nativelink/commit/15b455c1d7797dcf575aaa57e10e0736cd409877))
- Update README for more clarity ([#803](https://github.com/TraceMachina/nativelink/issues/803)) - ([31a1bf1](https://github.com/TraceMachina/nativelink/commit/31a1bf1e2e7c8ba73624bc998e20c2d551195866))

nit: Documentation.


CHANGELOG.md line 62 at r1 (raw file):

- Update Configuration.mdx ([#822](https://github.com/TraceMachina/nativelink/issues/822)) - ([15b455c](https://github.com/TraceMachina/nativelink/commit/15b455c1d7797dcf575aaa57e10e0736cd409877))
- Update README for more clarity ([#803](https://github.com/TraceMachina/nativelink/issues/803)) - ([31a1bf1](https://github.com/TraceMachina/nativelink/commit/31a1bf1e2e7c8ba73624bc998e20c2d551195866))
- Update node dependencies ([#805](https://github.com/TraceMachina/nativelink/issues/805)) - ([b6d4427](https://github.com/TraceMachina/nativelink/commit/b6d4427547f35d24763cbd921de3eab28e738e7c))

nit: Bump versions.


CHANGELOG.md line 63 at r1 (raw file):

- Update README for more clarity ([#803](https://github.com/TraceMachina/nativelink/issues/803)) - ([31a1bf1](https://github.com/TraceMachina/nativelink/commit/31a1bf1e2e7c8ba73624bc998e20c2d551195866))
- Update node dependencies ([#805](https://github.com/TraceMachina/nativelink/issues/805)) - ([b6d4427](https://github.com/TraceMachina/nativelink/commit/b6d4427547f35d24763cbd921de3eab28e738e7c))
- Update dependency platforms to v0.0.9 ([#784](https://github.com/TraceMachina/nativelink/issues/784)) - ([a6976e0](https://github.com/TraceMachina/nativelink/commit/a6976e095403dfd7cf03c554c8ce681af40622e5))

nit: Bump versions.


CHANGELOG.md line 64 at r1 (raw file):

- Update node dependencies ([#805](https://github.com/TraceMachina/nativelink/issues/805)) - ([b6d4427](https://github.com/TraceMachina/nativelink/commit/b6d4427547f35d24763cbd921de3eab28e738e7c))
- Update dependency platforms to v0.0.9 ([#784](https://github.com/TraceMachina/nativelink/issues/784)) - ([a6976e0](https://github.com/TraceMachina/nativelink/commit/a6976e095403dfd7cf03c554c8ce681af40622e5))
- Update dependency rules_java to v7.5.0 ([#780](https://github.com/TraceMachina/nativelink/issues/780)) - ([a6d0f64](https://github.com/TraceMachina/nativelink/commit/a6d0f64c219eb007ae32468d1a3d5915ec3f869c))

nit: Bump versions.


CHANGELOG.md line 65 at r1 (raw file):

- Update dependency platforms to v0.0.9 ([#784](https://github.com/TraceMachina/nativelink/issues/784)) - ([a6976e0](https://github.com/TraceMachina/nativelink/commit/a6976e095403dfd7cf03c554c8ce681af40622e5))
- Update dependency rules_java to v7.5.0 ([#780](https://github.com/TraceMachina/nativelink/issues/780)) - ([a6d0f64](https://github.com/TraceMachina/nativelink/commit/a6d0f64c219eb007ae32468d1a3d5915ec3f869c))
- Migrate Bazelisk actions to new variant ([#760](https://github.com/TraceMachina/nativelink/issues/760)) - ([3da42f2](https://github.com/TraceMachina/nativelink/commit/3da42f23badb78428d9868a24468bcbf00f069a7))

nit: Bump versions.


CHANGELOG.md line 66 at r1 (raw file):

- Update dependency rules_java to v7.5.0 ([#780](https://github.com/TraceMachina/nativelink/issues/780)) - ([a6d0f64](https://github.com/TraceMachina/nativelink/commit/a6d0f64c219eb007ae32468d1a3d5915ec3f869c))
- Migrate Bazelisk actions to new variant ([#760](https://github.com/TraceMachina/nativelink/issues/760)) - ([3da42f2](https://github.com/TraceMachina/nativelink/commit/3da42f23badb78428d9868a24468bcbf00f069a7))
- Update aws-sdk-rust monorepo ([#759](https://github.com/TraceMachina/nativelink/issues/759)) - ([4dc541e](https://github.com/TraceMachina/nativelink/commit/4dc541e7ccf21575522f98a7e5e4c12f16ad1560))

nit: Bump versions.


CHANGELOG.md line 67 at r1 (raw file):

- Migrate Bazelisk actions to new variant ([#760](https://github.com/TraceMachina/nativelink/issues/760)) - ([3da42f2](https://github.com/TraceMachina/nativelink/commit/3da42f23badb78428d9868a24468bcbf00f069a7))
- Update aws-sdk-rust monorepo ([#759](https://github.com/TraceMachina/nativelink/issues/759)) - ([4dc541e](https://github.com/TraceMachina/nativelink/commit/4dc541e7ccf21575522f98a7e5e4c12f16ad1560))
- Update TypeScript dependencies ([#753](https://github.com/TraceMachina/nativelink/issues/753)) - ([4163da1](https://github.com/TraceMachina/nativelink/commit/4163da1fb0277ad23becf52514ae9ee8271a7fa4))

nit: Bump versions.


CHANGELOG.md line 68 at r1 (raw file):

- Update aws-sdk-rust monorepo ([#759](https://github.com/TraceMachina/nativelink/issues/759)) - ([4dc541e](https://github.com/TraceMachina/nativelink/commit/4dc541e7ccf21575522f98a7e5e4c12f16ad1560))
- Update TypeScript dependencies ([#753](https://github.com/TraceMachina/nativelink/issues/753)) - ([4163da1](https://github.com/TraceMachina/nativelink/commit/4163da1fb0277ad23becf52514ae9ee8271a7fa4))
- Update step-security/harden-runner action to v2.7.0 ([#718](https://github.com/TraceMachina/nativelink/issues/718)) - ([44cb709](https://github.com/TraceMachina/nativelink/commit/44cb709aabd4e2f5ae3fdf7c552039c233089a97))

nit: Bump versions.


CHANGELOG.md line 69 at r1 (raw file):

- Update TypeScript dependencies ([#753](https://github.com/TraceMachina/nativelink/issues/753)) - ([4163da1](https://github.com/TraceMachina/nativelink/commit/4163da1fb0277ad23becf52514ae9ee8271a7fa4))
- Update step-security/harden-runner action to v2.7.0 ([#718](https://github.com/TraceMachina/nativelink/issues/718)) - ([44cb709](https://github.com/TraceMachina/nativelink/commit/44cb709aabd4e2f5ae3fdf7c552039c233089a97))
- Update dependency rules_java to v7.4.0 ([#715](https://github.com/TraceMachina/nativelink/issues/715)) - ([6058d6a](https://github.com/TraceMachina/nativelink/commit/6058d6a80eefe06e83acd5e8f601201390f4a7b8))

nit: Bump versions.


CHANGELOG.md line 73 at r1 (raw file):

- Rename missing `turbo-cache` to `nativelink` ([#663](https://github.com/TraceMachina/nativelink/issues/663)) - ([f8044e6](https://github.com/TraceMachina/nativelink/commit/f8044e66959c52d3cfca840f178f73329e872869))
- Migrate to Bzlmod ([#626](https://github.com/TraceMachina/nativelink/issues/626)) - ([2a89ce6](https://github.com/TraceMachina/nativelink/commit/2a89ce6384b428869e21219af303c753bd3087b5))
- EvictingMap should evict keys on all public access. ([#601](https://github.com/TraceMachina/nativelink/issues/601)) - ([56a0972](https://github.com/TraceMachina/nativelink/commit/56a0972402cb8ec5df04da8ee4cd307ed3650f28))

nit: Bug Fix.


CHANGELOG.md line 76 at r1 (raw file):

- Separate K8s setup steps in CI ([#614](https://github.com/TraceMachina/nativelink/issues/614)) - ([82d9ee6](https://github.com/TraceMachina/nativelink/commit/82d9ee6508df807f284b1a0faf6f22b29ee534e3))
- Migrate Mintlify to Docusaurus ([#586](https://github.com/TraceMachina/nativelink/issues/586)) - ([7247385](https://github.com/TraceMachina/nativelink/commit/7247385e9508418f56a5b3a9d3035423484c5830))
- Update README.md ([#580](https://github.com/TraceMachina/nativelink/issues/580)) - ([0269835](https://github.com/TraceMachina/nativelink/commit/0269835f84e550943754cc5d2aa685c21dae05ef))

nit: Documentation.


CHANGELOG.md line 140 at r1 (raw file):

### ⚙️ Miscellaneous

- Resolve upload deadlock ([#816](https://github.com/TraceMachina/nativelink/issues/816)) - ([b61142d](https://github.com/TraceMachina/nativelink/commit/b61142dd9c9dc3e85d9adc8a23668f9ad234c128))

nit: Bug Fix.


CHANGELOG.md line 141 at r1 (raw file):

- Resolve upload deadlock ([#816](https://github.com/TraceMachina/nativelink/issues/816)) - ([b61142d](https://github.com/TraceMachina/nativelink/commit/b61142dd9c9dc3e85d9adc8a23668f9ad234c128))
- Example of chromium using deployment scripts ([#786](https://github.com/TraceMachina/nativelink/issues/786)) - ([0aa7f65](https://github.com/TraceMachina/nativelink/commit/0aa7f65c5a037e3ae3f7b5b79ed285d593b2f214))

nit: Documentation.


CHANGELOG.md line 143 at r1 (raw file):

- Example of chromium using deployment scripts ([#786](https://github.com/TraceMachina/nativelink/issues/786)) - ([0aa7f65](https://github.com/TraceMachina/nativelink/commit/0aa7f65c5a037e3ae3f7b5b79ed285d593b2f214))
- Generalize Kubernetes worker setup ([#812](https://github.com/TraceMachina/nativelink/issues/812)) - ([4146a34](https://github.com/TraceMachina/nativelink/commit/4146a341a7c0bc31a74296fcb06550f05163eceb))
- Create directory for action ([#752](https://github.com/TraceMachina/nativelink/issues/752)) - ([414fff3](https://github.com/TraceMachina/nativelink/commit/414fff35ef82259a434dbdb14c13036a0d22c9c4))

nit: Feature.


CHANGELOG.md line 144 at r1 (raw file):

- Generalize Kubernetes worker setup ([#812](https://github.com/TraceMachina/nativelink/issues/812)) - ([4146a34](https://github.com/TraceMachina/nativelink/commit/4146a341a7c0bc31a74296fcb06550f05163eceb))
- Create directory for action ([#752](https://github.com/TraceMachina/nativelink/issues/752)) - ([414fff3](https://github.com/TraceMachina/nativelink/commit/414fff35ef82259a434dbdb14c13036a0d22c9c4))
-  Unify RunningAction and AwaitedAction ([#782](https://github.com/TraceMachina/nativelink/issues/782)) - ([7997f03](https://github.com/TraceMachina/nativelink/commit/7997f03a9426c2778863fea35e585bd752ab6930))

nit: Refactor.


CHANGELOG.md line 145 at r1 (raw file):

- Create directory for action ([#752](https://github.com/TraceMachina/nativelink/issues/752)) - ([414fff3](https://github.com/TraceMachina/nativelink/commit/414fff35ef82259a434dbdb14c13036a0d22c9c4))
-  Unify RunningAction and AwaitedAction ([#782](https://github.com/TraceMachina/nativelink/issues/782)) - ([7997f03](https://github.com/TraceMachina/nativelink/commit/7997f03a9426c2778863fea35e585bd752ab6930))
- Allow variables in platform property values ([#809](https://github.com/TraceMachina/nativelink/issues/809)) - ([09fc7f8](https://github.com/TraceMachina/nativelink/commit/09fc7f8561568e0e7a1500b069d64e6499421a66))

nit: Feature


CHANGELOG.md line 148 at r1 (raw file):

- Forbid binary files in commits ([#792](https://github.com/TraceMachina/nativelink/issues/792)) - ([d9fc4ad](https://github.com/TraceMachina/nativelink/commit/d9fc4adf71f6680846c7ebd9c2878d02a8aad185))
- Don't update rustup in native Cargo workflow ([#775](https://github.com/TraceMachina/nativelink/issues/775)) - ([9d49514](https://github.com/TraceMachina/nativelink/commit/9d4951498547f6550ee71d47e0f9609a463993ee))
- Unbreak CI ([#769](https://github.com/TraceMachina/nativelink/issues/769)) - ([682c4fe](https://github.com/TraceMachina/nativelink/commit/682c4feee39b72eb34338e6148c580359a343afc))

nit: Testing.


CHANGELOG.md line 149 at r1 (raw file):

- Don't update rustup in native Cargo workflow ([#775](https://github.com/TraceMachina/nativelink/issues/775)) - ([9d49514](https://github.com/TraceMachina/nativelink/commit/9d4951498547f6550ee71d47e0f9609a463993ee))
- Unbreak CI ([#769](https://github.com/TraceMachina/nativelink/issues/769)) - ([682c4fe](https://github.com/TraceMachina/nativelink/commit/682c4feee39b72eb34338e6148c580359a343afc))
- Completeness checking store should not check if directory digests exist ([#748](https://github.com/TraceMachina/nativelink/issues/748)) - ([e979e31](https://github.com/TraceMachina/nativelink/commit/e979e31cce278989f9673e9b0fdb057b08d1af20))

nit: Bug Fix.


CHANGELOG.md line 152 at r1 (raw file):

- Ignore .direnv for bazel builds ([#756](https://github.com/TraceMachina/nativelink/issues/756)) - ([a15bdb6](https://github.com/TraceMachina/nativelink/commit/a15bdb679a2149a1637d5d1f13d97b2b80587124))
- Set max line length to Rust's defaults ([#750](https://github.com/TraceMachina/nativelink/issues/750)) - ([a876cce](https://github.com/TraceMachina/nativelink/commit/a876ccea65317b512808788c1e26590f3f3b3f02))
- Use mimalloc as global memory allocator ([#749](https://github.com/TraceMachina/nativelink/issues/749)) - ([6c647d6](https://github.com/TraceMachina/nativelink/commit/6c647d68e2bdc349fad0a67de6b05a1a91aeb031))

nit: Feature.


CHANGELOG.md line 153 at r1 (raw file):

- Set max line length to Rust's defaults ([#750](https://github.com/TraceMachina/nativelink/issues/750)) - ([a876cce](https://github.com/TraceMachina/nativelink/commit/a876ccea65317b512808788c1e26590f3f3b3f02))
- Use mimalloc as global memory allocator ([#749](https://github.com/TraceMachina/nativelink/issues/749)) - ([6c647d6](https://github.com/TraceMachina/nativelink/commit/6c647d68e2bdc349fad0a67de6b05a1a91aeb031))
- Refactor fs.rs to use call_with_permit scheme ([#741](https://github.com/TraceMachina/nativelink/issues/741)) - ([011318a](https://github.com/TraceMachina/nativelink/commit/011318a7af82d6dcb1d6ffb34af38b159513820c))

nit: Refactor


CHANGELOG.md line 155 at r1 (raw file):

- Refactor fs.rs to use call_with_permit scheme ([#741](https://github.com/TraceMachina/nativelink/issues/741)) - ([011318a](https://github.com/TraceMachina/nativelink/commit/011318a7af82d6dcb1d6ffb34af38b159513820c))
- Improve the error message in resource info parsing failure ([#742](https://github.com/TraceMachina/nativelink/issues/742)) - ([3e6f154](https://github.com/TraceMachina/nativelink/commit/3e6f154471e70d37244a66849b1c94a00c1f313f))
- Starts a Breakdown of Configuration ([#680](https://github.com/TraceMachina/nativelink/issues/680)) - ([433829c](https://github.com/TraceMachina/nativelink/commit/433829c961681b7d6bc8ba77384f200def12ba5e))

nit: Documentation.


CHANGELOG.md line 156 at r1 (raw file):

- Improve the error message in resource info parsing failure ([#742](https://github.com/TraceMachina/nativelink/issues/742)) - ([3e6f154](https://github.com/TraceMachina/nativelink/commit/3e6f154471e70d37244a66849b1c94a00c1f313f))
- Starts a Breakdown of Configuration ([#680](https://github.com/TraceMachina/nativelink/issues/680)) - ([433829c](https://github.com/TraceMachina/nativelink/commit/433829c961681b7d6bc8ba77384f200def12ba5e))
- Optimize file uploads when source is file ([#723](https://github.com/TraceMachina/nativelink/issues/723)) - ([7c9a070](https://github.com/TraceMachina/nativelink/commit/7c9a07085298d1546b4459d6a22ec87bf8189395))

nit: Refactor


CHANGELOG.md line 157 at r1 (raw file):

- Starts a Breakdown of Configuration ([#680](https://github.com/TraceMachina/nativelink/issues/680)) - ([433829c](https://github.com/TraceMachina/nativelink/commit/433829c961681b7d6bc8ba77384f200def12ba5e))
- Optimize file uploads when source is file ([#723](https://github.com/TraceMachina/nativelink/issues/723)) - ([7c9a070](https://github.com/TraceMachina/nativelink/commit/7c9a07085298d1546b4459d6a22ec87bf8189395))
- Draw a General Purpose Diagram ([#705](https://github.com/TraceMachina/nativelink/issues/705)) - ([2c102c3](https://github.com/TraceMachina/nativelink/commit/2c102c35a082bc935753b25f0df02f8cf47978b9))

nit: Documentation.


CHANGELOG.md line 158 at r1 (raw file):

- Optimize file uploads when source is file ([#723](https://github.com/TraceMachina/nativelink/issues/723)) - ([7c9a070](https://github.com/TraceMachina/nativelink/commit/7c9a07085298d1546b4459d6a22ec87bf8189395))
- Draw a General Purpose Diagram ([#705](https://github.com/TraceMachina/nativelink/issues/705)) - ([2c102c3](https://github.com/TraceMachina/nativelink/commit/2c102c35a082bc935753b25f0df02f8cf47978b9))
- Cleanup hash functions to be more idomatic ([#691](https://github.com/TraceMachina/nativelink/issues/691)) - ([8dd786a](https://github.com/TraceMachina/nativelink/commit/8dd786aca82706145e3d7f32dc2250ddb41e69a9))

nit: Refactor.


CHANGELOG.md line 159 at r1 (raw file):

- Draw a General Purpose Diagram ([#705](https://github.com/TraceMachina/nativelink/issues/705)) - ([2c102c3](https://github.com/TraceMachina/nativelink/commit/2c102c35a082bc935753b25f0df02f8cf47978b9))
- Cleanup hash functions to be more idomatic ([#691](https://github.com/TraceMachina/nativelink/issues/691)) - ([8dd786a](https://github.com/TraceMachina/nativelink/commit/8dd786aca82706145e3d7f32dc2250ddb41e69a9))
- Basic config updated. ([#669](https://github.com/TraceMachina/nativelink/issues/669)) - ([f4d9db3](https://github.com/TraceMachina/nativelink/commit/f4d9db3c12eb75495f642e7d176a7d078d0de193))

nit: Documentation.


CHANGELOG.md line 163 at r1 (raw file):

- Adjust all instances of Native Link in comments and metadata to NativeLink ([#658](https://github.com/TraceMachina/nativelink/issues/658)) - ([4e7d68b](https://github.com/TraceMachina/nativelink/commit/4e7d68bb1ed6fe8daef9f40ea378a43ac16af956))
- Remove Alpha notice ([#657](https://github.com/TraceMachina/nativelink/issues/657)) - ([a9526b1](https://github.com/TraceMachina/nativelink/commit/a9526b1764e958a947c1b80481419f9d98ff6e26))
- GrpcStore Write Retry ([#638](https://github.com/TraceMachina/nativelink/issues/638)) - ([9f7f45d](https://github.com/TraceMachina/nativelink/commit/9f7f45d626d1f8e9844d4d177250b5274e2bd85d))

nit: Refactor.


CHANGELOG.md line 164 at r1 (raw file):

- Remove Alpha notice ([#657](https://github.com/TraceMachina/nativelink/issues/657)) - ([a9526b1](https://github.com/TraceMachina/nativelink/commit/a9526b1764e958a947c1b80481419f9d98ff6e26))
- GrpcStore Write Retry ([#638](https://github.com/TraceMachina/nativelink/issues/638)) - ([9f7f45d](https://github.com/TraceMachina/nativelink/commit/9f7f45d626d1f8e9844d4d177250b5274e2bd85d))
- Don't retry permanent failures ([#634](https://github.com/TraceMachina/nativelink/issues/634)) - ([81b64f7](https://github.com/TraceMachina/nativelink/commit/81b64f73e207ad0ae2d87f531f9e93657b11ffd1))

nit: Bug Fix.


CHANGELOG.md line 166 at r1 (raw file):

- Don't retry permanent failures ([#634](https://github.com/TraceMachina/nativelink/issues/634)) - ([81b64f7](https://github.com/TraceMachina/nativelink/commit/81b64f73e207ad0ae2d87f531f9e93657b11ffd1))
- Create workflow for syncing Notion and Issues ([#642](https://github.com/TraceMachina/nativelink/issues/642)) - ([5470857](https://github.com/TraceMachina/nativelink/commit/54708570c32dcf15acbdfcac77084e68ef860c7a))
- Retry GrpcStore get_part_ref ([#646](https://github.com/TraceMachina/nativelink/issues/646)) - ([d46180c](https://github.com/TraceMachina/nativelink/commit/d46180c5f4ed548346c227a0e52ecc60994baf34))

nit: Feature.


CHANGELOG.md line 167 at r1 (raw file):

- Create workflow for syncing Notion and Issues ([#642](https://github.com/TraceMachina/nativelink/issues/642)) - ([5470857](https://github.com/TraceMachina/nativelink/commit/54708570c32dcf15acbdfcac77084e68ef860c7a))
- Retry GrpcStore get_part_ref ([#646](https://github.com/TraceMachina/nativelink/issues/646)) - ([d46180c](https://github.com/TraceMachina/nativelink/commit/d46180c5f4ed548346c227a0e52ecc60994baf34))
- Evict on touch failure ([#613](https://github.com/TraceMachina/nativelink/issues/613)) - ([3037a66](https://github.com/TraceMachina/nativelink/commit/3037a6625ac98b1e46a70c61ad6160c9a7668809))

nit: Bug Fix.


CHANGELOG.md line 169 at r1 (raw file):

- Evict on touch failure ([#613](https://github.com/TraceMachina/nativelink/issues/613)) - ([3037a66](https://github.com/TraceMachina/nativelink/commit/3037a6625ac98b1e46a70c61ad6160c9a7668809))
- Ignore fast store ([#633](https://github.com/TraceMachina/nativelink/issues/633)) - ([f9f7908](https://github.com/TraceMachina/nativelink/commit/f9f79085ac279327428cedda0921aca517c30a7f))
- Improve the LRE README ([#637](https://github.com/TraceMachina/nativelink/issues/637)) - ([63826f2](https://github.com/TraceMachina/nativelink/commit/63826f2ea47ba881c7ff05c5eb70b07cff0256e5))

nit: Documentation.


CHANGELOG.md line 171 at r1 (raw file):

- Improve the LRE README ([#637](https://github.com/TraceMachina/nativelink/issues/637)) - ([63826f2](https://github.com/TraceMachina/nativelink/commit/63826f2ea47ba881c7ff05c5eb70b07cff0256e5))
- Don't cache sanitizer workflows ([#630](https://github.com/TraceMachina/nativelink/issues/630)) - ([ae92fb3](https://github.com/TraceMachina/nativelink/commit/ae92fb30ea00f185118bc11209d53085c70830b8))
- GrpcStore retry first ([#616](https://github.com/TraceMachina/nativelink/issues/616)) - ([30887a9](https://github.com/TraceMachina/nativelink/commit/30887a955f0d1088dddd823d881c197be7ddaf23))

nit: Refactor.


CHANGELOG.md line 174 at r1 (raw file):

- Helpful Error Output for Integration Test ([#625](https://github.com/TraceMachina/nativelink/issues/625)) - ([39c6678](https://github.com/TraceMachina/nativelink/commit/39c66781284869d284e4e7168a52b387e2e5f2ae))
- Enable blake3 for Bazel builds ([#565](https://github.com/TraceMachina/nativelink/issues/565)) - ([5744813](https://github.com/TraceMachina/nativelink/commit/57448134b24e2a73e02342af05871e0d40a250a9))
- Build nativelink with musl ([#583](https://github.com/TraceMachina/nativelink/issues/583)) - ([ee4846c](https://github.com/TraceMachina/nativelink/commit/ee4846c238780ce66a52fb7bce08bb7ee4d3e5bc))

nit: Feature.

Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: 1 of 5 LGTMs obtained, and 46 discussions need to be resolved (waiting on @allada, @blakehatch, @MarcusSorealheis, and @zbirenbaum)

Copy link
Contributor

@blakehatch blakehatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 2 of 5 LGTMs obtained, and 46 discussions need to be resolved (waiting on @allada, @MarcusSorealheis, and @zbirenbaum)

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 3 of 5 LGTMs obtained, and 46 discussions need to be resolved (waiting on @allada and @zbirenbaum)

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 3 of 5 LGTMs obtained, and 46 discussions need to be resolved (waiting on @allada and @zbirenbaum)

Copy link
Contributor

@zbirenbaum zbirenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 4 of 5 LGTMs obtained, and 46 discussions need to be resolved (waiting on @allada)

Copy link
Contributor

@zbirenbaum zbirenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 4 of 5 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Vercel, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable, zig-cc ubuntu-20.04, zig-cc ubuntu-22.04, and 46 discussions need to be resolved (waiting on @allada)

Copy link
Contributor Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Bazel Dev / ubuntu-22.04, Vercel, integration-tests (20.04), pre-commit-checks, and 1 discussions need to be resolved (waiting on @allada)


CHANGELOG.md line 41 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

nit: Bump versions.

This is correct.

Copy link
Contributor Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-@allada

Reviewed 3 of 14 files at r1, 10 of 12 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 4 of 4 LGTMs obtained, and 1 discussions need to be resolved

@aaronmondal aaronmondal removed the request for review from allada April 9, 2024 21:49
@aaronmondal aaronmondal merged commit f96ee92 into TraceMachina:main Apr 9, 2024
26 checks passed
aaronmondal added a commit to aaronmondal/nativelink that referenced this pull request Apr 9, 2024
* Release NativeLink v0.3.0 (TraceMachina#838)

* Fix semver image workflow
aaronmondal added a commit that referenced this pull request Apr 9, 2024
aaronmondal added a commit that referenced this pull request Apr 9, 2024
This reverts commit f96ee92.

The tag workflow is broken and needs to be fixed first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants