Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hedera): added support for hedera network by krypc team #4

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

piruthivi3232
Copy link

No description provided.

@superical
Copy link

Pls fix the issues.

@piruthivi3232
Copy link
Author

Pls fix the issues.

Fixed

@superical
Copy link

Still fail.

@piruthivi3232
Copy link
Author

Still fail.

subject added

@piruthivi3232
Copy link
Author

plz close this as soon as possible

@superical
Copy link

plz close this as soon as possible

You still have linter issues. Pls fix all your issues in one shot if you would like to close this sooner. It’s going to take multiple rounds like now if you are only fixing some but not the rest of the issues.

@piruthivi3232 piruthivi3232 changed the title Added support for Hedera network by KrypC Team feat: Added support for Hedera network by KrypC Team Nov 8, 2023
@piruthivi3232
Copy link
Author

I have changed the commit msg, guide me if i am wrong

@superical
Copy link

Your PR is still failing. Pls fix the issues.

@piruthivi3232
Copy link
Author

commit message changed

@piruthivi3232
Copy link
Author

i have corrected commit msg.

@superical
Copy link

Please correct all commit msg.

@piruthivi3232 piruthivi3232 changed the title feat: Added support for Hedera network by KrypC Team feat(hedera): added support for hedera network by krypc team Nov 21, 2023
we have added mainnet and testnet hedera network configurations.
@piruthivi3232
Copy link
Author

I revised my commit message in accordance with the guidelines provided at https://commitlint.io/

@piruthivi3232
Copy link
Author

checklist passed please merge.

@piruthivi3232
Copy link
Author

when it will merge?

@superical
Copy link

This PR was already approved a few weeks ago. You can merge whenever you're ready.

@superical superical merged commit b14e3eb into TradeTrust:master Dec 6, 2023
5 checks passed
Copy link

github-actions bot commented Dec 6, 2023

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants