🔨 remove state.nb, rename getNb to getLength

README.md

@@ -156,9 +156,9 @@ Selectors are:
 | `getBy(<propertyPath>, <value>)(state)` | get data specified by the field you want to filter with (take care, selectors are not memoized) | Example: `getBy('visible', true)(state)` returns all visible todos.
 | `getKeys(state)` | returns all store keys (in array) | |
 | `getAsArray(state)` | returns all data in array (raw) | |
-| `getNb(state)` | returns number of stored instances | |
+| `getLength(state)` | returns number of stored instances | |
 | `isInitialized(state)` | return true if the store has been initialized (by `add` or by `set` action) | |
-| `getState(state)` | returns the global state of your reducer | The global state contains :<ul><li>`data`: key/value store</li><li>`array`: raw data</li><li>`keys`: keys array</li><li>`nb`: store length</li><li>`initialized`: boolean (set to true by `set` and `add` actions)</li></ul>
+| `getState(state)` | returns the global state of your reducer | The global state contains :<ul><li>`data`: key/value store</li><li>`array`: raw data</li><li>`keys`: keys array</li><li>`initialized`: boolean (set to true by `set` and `add` actions)</li></ul>
 
 Example, we retrieve the todo with id `1`:
 ```es6

src/__snapshots__/index.spec.js.snap

@@ -28,7 +28,6 @@ Object {
     1,
     2,
   ],
-  "nb": 2,
 }
 `;
 
@@ -77,7 +76,6 @@ Object {
     1,
     2,
   ],
-  "nb": 2,
 }
 `;
 

src/__snapshots__/reducer.spec.js.snap

@@ -53,7 +53,6 @@ Object {
     "elm3",
     "elm4",
   ],
-  "nb": 4,
 }
 `;
 
@@ -77,7 +76,6 @@ Object {
   "keys": Array [
     "elm4",
   ],
-  "nb": 1,
 }
 `;
 
@@ -112,7 +110,6 @@ Object {
     "elm2",
     "elm3",
   ],
-  "nb": 2,
 }
 `;
 
@@ -122,7 +119,6 @@ Object {
   "data": Object {},
   "initialized": false,
   "keys": Array [],
-  "nb": 0,
 }
 `;
 
@@ -132,7 +128,6 @@ Object {
   "data": Object {},
   "initialized": false,
   "keys": Array [],
-  "nb": 0,
 }
 `;
 
@@ -167,6 +162,5 @@ Object {
     "elm1",
     "elm2",
   ],
-  "nb": 2,
 }
 `;

src/__snapshots__/selectors.spec.js.snap

@@ -173,7 +173,7 @@ Array [
 ]
 `;
 
-exports[`selectors should retrieve nb 1`] = `5`;
+exports[`selectors should retrieve length 1`] = `5`;
 
 exports[`selectors should retrieve state 1`] = `
 Object {
@@ -251,7 +251,6 @@ Object {
     "elm4",
     "elm5",
   ],
-  "nb": 5,
 }
 `;
 
@@ -331,6 +330,5 @@ Object {
     "elm4",
     "elm5",
   ],
-  "nb": 5,
 }
 `;

src/index.spec.js

@@ -10,7 +10,6 @@ const subState = {
     2: Todo(2),
   },
   keys: [1, 20, 2],
-  nb: 3,
   initialized: true,
 }
 

src/reducer.js

@@ -1,7 +1,7 @@
 import { keyBy, without, uniq, omit } from 'lodash'
 import { SET, ADD, DEL, RESET } from './actions'
 
-export const initState = { data: {}, keys: [], array: [], nb: 0, initialized: false }
+export const initState = { data: {}, keys: [], array: [], initialized: false }
 
 export default key => prefix =>
   (state = initState, { type = 'UNKONWN', payload } = {}) => {
@@ -11,7 +11,6 @@ export default key => prefix =>
           data: keyBy(payload, key),
           keys: payload.map(element => element[key]),
           array: payload,
-          nb: payload.length,
           initialized: true,
         }
       case ADD(prefix):
@@ -20,7 +19,6 @@ export default key => prefix =>
           data: { ...state.data, [payload[key]]: payload },
           keys: uniq([...state.keys, payload[key]]),
           array: [...state.array, payload],
-          nb: state.keys.length + 1,
           initialized: true,
         }
       case DEL(prefix):
@@ -29,7 +27,6 @@ export default key => prefix =>
           data: omit(state.data, [payload]),
           keys: without(state.keys, payload),
           array: state.array ? state.array.filter(o => o[key] !== payload) : [],
-          nb: state.keys.length - 1,
         }
       case RESET(prefix):
         return initState

src/reducer.spec.js

@@ -12,7 +12,6 @@ const state = {
   },
   keys: ['elm2', 'elm1', 'elm3'],
   array: [Element('elm2'), Element('elm1'), Element('elm3')],
-  nb: 3,
   initialized: false,
 }
 

src/selectors.js

@@ -10,7 +10,7 @@ export const getState = path => prefix => (state) => {
 const getFactory = key => path => prefix => state => getState(path)(prefix)(state)[key]
 export const getKeys = getFactory('keys')
 export const getAsArray = getFactory('array')
-export const getNb = getFactory('nb')
+export const getLength = path => prefix => state => getKeys(path)(prefix)(state).length
 export const isInitialized = getFactory('initialized')
 
 const getData = getFactory('data')

src/selectors.spec.js

@@ -1,5 +1,5 @@
 /* eslint-env jest */
-import { getKeys, getNb, getState, get, getBy, getAsArray, isInitialized } from './selectors'
+import { getKeys, getLength, getState, get, getBy, getAsArray, isInitialized } from './selectors'
 
 const Element = code => ({ code, some: 'other', infos: code })
 const SubElement = code => subCode => ({ ...Element(code), sub: { subCode } })
@@ -17,7 +17,6 @@ const subState = {
     },
     keys: ['elm2', 'elm1', 'elm3', 'elm4', 'elm5'],
     array: [Element('elm2'), Element('elm1'), Element('elm3'), SubElement('elm4')('subelm4'), SubElement('elm5')('subelm5')],
-    nb: 5,
     initialized: true,
   },
 }
@@ -33,7 +32,7 @@ describe('selectors', () => {
   it('should retrieve state', () => expect(getState(path)(prefix)(state)).toMatchSnapshot())
   it('should retrieve state, without path set', () => expect(getState()(prefix)(subState)).toMatchSnapshot())
   it('should retrieve keys', () => expect(getKeys(path)(prefix)(state)).toMatchSnapshot())
-  it('should retrieve nb', () => expect(getNb(path)(prefix)(state)).toMatchSnapshot())
+  it('should retrieve length', () => expect(getLength(path)(prefix)(state)).toMatchSnapshot())
   it('should retrieve initialized value', () => expect(isInitialized(path)(prefix)(state)).toMatchSnapshot())
   it('should retrieve all data, without key', () => expect(get(path)(prefix)()(state)).toMatchSnapshot())
   it('should retrieve data by ids, with an array of keys', () => expect(get(path)(prefix)(['elm1', 'elm3'])(state)).toMatchSnapshot())