use batch api always

taraspos · Feb 20, 2020 · 4fe2398 · 4fe2398
1 parent c30e406
commit 4fe2398
Showing 1 changed file with 15 additions and 17 deletions.
diff --git a/metrics/cloudwatch/cloudwatch.go b/metrics/cloudwatch/cloudwatch.go
@@ -181,25 +181,23 @@ func (cw *CloudWatch) Send() error {
 			Timestamp:  aws.Time(now),
 		}
 
-		if l := len(values); l > 1 {
-			// CloudWatch Put Metrics API (https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html)
-			// expects batch of unique values including the array of corresponding counts
-			valuesCounter := make(map[float64]int)
-			for _, v := range values {
-				valuesCounter[v]++
-			}
+		if len(values) == 0 {
+			return true
+		}
 
-			for value, count := range valuesCounter {
-				if len(datum.Values) == maxValuesInABatch {
-					break
-				}
-				datum.Values = append(datum.Values, aws.Float64(value))
-				datum.Counts = append(datum.Counts, aws.Float64(float64(count)))
+		// CloudWatch Put Metrics API (https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html)
+		// expects batch of unique values including the array of corresponding counts
+		valuesCounter := make(map[float64]int)
+		for _, v := range values {
+			valuesCounter[v]++
+		}
+
+		for value, count := range valuesCounter {
+			if len(datum.Values) == maxValuesInABatch {
+				break
 			}
-		} else if l == 1 {
-			datum.Value = aws.Float64(values[0])
-		} else {
-			return true
+			datum.Values = append(datum.Values, aws.Float64(value))
+			datum.Counts = append(datum.Counts, aws.Float64(float64(count)))
 		}
 
 		datums = append(datums, datum)