-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the canonical label and Biolink type to NameRes results #43
Comments
Of course the downside here is that it makes the solr documents even that much bigger |
The current docs look like this, I think:
If we need to add the type and preferred name to every element, then oof. I wonder if we could transform the docs to something more like
That way the percent diff of adding the new info is paid for in the reduction of curie repetition. |
The other option would be for NameRes to include a Redis table that has id to canonical name + biolink type mappings, but that would complicate the backend.
I like this! NameRes is loaded from the synonym file, which is currently in the format:
I think we if modify this to:
We could use Solr updates to load it in the format you suggest. The synonym files would then get much larger, but the Solr database -- which is the piece we have to transfer from RENCI to ITRB -- might end up being smaller because it has fewer documents in it. Is it okay to drop the |
I think it is being used to order the synonyms when they get grouped by curie. But I think if we put all the names in one document we wouldn't need to do that (and could therefore lose it). I think that it's worth giving this a shot and seeing whether it works or not. |
At the moment, the Translator UI queries NameRes to find identifiers to display, then queries NodeNorm for the canonical label, Biolink type and other information. Both the canonical label and the Biolink type (as needed for #39 anyway) would be great to include in the NodeNorm results so that a second NodeNorm query is not needed.
The text was updated successfully, but these errors were encountered: