Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include version number in NameRes and maybe some kind of notification on updates #45

Open
gaurav opened this issue Mar 8, 2023 · 1 comment

Comments

@gaurav
Copy link
Contributor

gaurav commented Mar 8, 2023

If we could incorporate the Babel version number (e.g. 2022oct13) into the NodeNorm Swagger version number (currently 2.0.9 from the Babel image), then a user could know what version was being used, and could refer to it in issues or look it up in downloads.

@gaurav
Copy link
Contributor Author

gaurav commented Jun 22, 2023

We store this information in the https://github.com/helxplatform/translator-devops/blob/e158e6264b894d85a761ce10ebfdb8f7c387ff25/helm/name-lookup/values.yaml file, so the easiest way to do this would be to store the Babel in an environmental variable, and then load it into the Python program. However, the obvious place to put this information is in api/resources/openapi.yml, which we use verbatim. So either:

  • We need to modify this file on the fly while creating the instance, or
  • We need to have the Python script modify the version while loading it, or
  • We need another endpoint to provide this information, which can load that from the environmental variable we end up using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant