Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poisson_nll_loss in pytorch frontend #10531

Merged
merged 8 commits into from
Feb 26, 2023
Merged

poisson_nll_loss in pytorch frontend #10531

merged 8 commits into from
Feb 26, 2023

Conversation

tomatillos
Copy link
Contributor

@tomatillos tomatillos commented Feb 14, 2023

Close #10484

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Feb 14, 2023
@tomatillos
Copy link
Contributor Author

@YushaArif99 Any chance you could look at this?

Copy link
Contributor

@YushaArif99 YushaArif99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tomatillos

Extremely sorry for the late reply. I was busy with exams and so didn't get the time to review PRs. Have a whole stack of pending PRs awaiting my review 😅 . Will try blasting through them by today hopefully 🤞🏼

With regards to your PR, all the changes look good to me and the relevant CI tests are also passing. I will now be merging this PR.

Thanks a lot for the contribution and once again apologies for the delay 😃

@YushaArif99 YushaArif99 merged commit b813481 into ivy-llc:master Feb 26, 2023
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Added poisson_nll_loss to the PyTorch frontend. 

Co-authored-by: Yusha Arif <101613943+YushaArif99@users.noreply.github.com>
vedpatwardhan pushed a commit to vedpatwardhan/ivy that referenced this pull request Feb 26, 2023
Added poisson_nll_loss to the PyTorch frontend. 

Co-authored-by: Yusha Arif <101613943+YushaArif99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poisson_nll_loss
3 participants