Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy, torch-frontend): Extends ivy.multi_head_attention and shortens torch_frontend.multi_head_attention_forward #23131

Merged
merged 84 commits into from
Sep 27, 2023

Conversation

AnnaTz
Copy link
Contributor

@AnnaTz AnnaTz commented Sep 6, 2023

Extending ivy.multi_head_attention to the superset, and shortening torch_frontend.multi_head_attention_forward by using the updated ivy.multi_head_attention.

Close #23074

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@AnnaTz AnnaTz changed the title refactor(ivy, frontends): Extends ivy.multi_head_attention and shortens torch_frontend.multi_head_attention_forward refactor(ivy, torch-frontend): Extends ivy.multi_head_attention and shortens torch_frontend.multi_head_attention_forward Sep 6, 2023
@ivy-leaves ivy-leaves added PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API labels Sep 6, 2023
@ivy-leaves ivy-leaves added the Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards label Sep 7, 2023
@AnnaTz AnnaTz marked this pull request as ready for review September 27, 2023 15:13
@AnnaTz AnnaTz merged commit dfe5ea0 into ivy-llc:main Sep 27, 2023
91 of 136 checks passed
@AnnaTz AnnaTz deleted the mha branch October 9, 2023 11:10
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
…hortens torch_frontend.multi_head_attention_forward (ivy-llc#23131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy Functional API PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi_head_attention_forward - 70 LOC
5 participants