Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip tensorflow.zeros tests for Paddle backend with ndim >= 10 #23156

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

akshatvishu
Copy link
Contributor

PR Description:

Added a condition to skip tests in "test_tensorflow_zeros" when using the Paddle backend and the dimension is 10 or more.

This is a temporary measure until the Paddle backend supports dimensions greater than 9.

Related Issue:

Close #23155

Added a condition to skip tests in "test_tensorflow_zeros" when using the Paddle backend and the dimension is 10 or more.

This is a temporary measure until the Paddle backend supports dimensions greater than 9.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Sep 6, 2023
@akshatvishu
Copy link
Contributor Author

akshatvishu commented Sep 6, 2023

Do tell if doing something like this would be better than the current solution!
test: LINK

# zeros
@handle_frontend_test(
    fn_tree="tensorflow.zeros",
    input=helpers.get_shape(
        allow_none=False,
        min_num_dims=0,
        max_num_dims=9,# CHANGE
        min_dim_size=0,
        max_dim_size=9, # CHANGE
    ),
    dtype=helpers.get_dtypes("valid", full=False),
)

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akshatvishu
I think the solution posed in the comment above might work better. The current solution does not fix the test as can be seen in the logs by searching for test_tensorflow_zeros,paddle which still gives the error Invalid dimension to be accessed. Now only supports access to dimension 0 to 9, but received dimension is 10.. Could you perhaps update and test. Thanks 🙂️

…t equal to 9 as

PaddlePaddle only support till 9 dims.
@akshatvishu
Copy link
Contributor Author

akshatvishu commented Oct 4, 2023

Hi @akshatvishu I think the solution posed in the comment above might work better. The current solution does not fix the test as can be seen in the logs by searching for test_tensorflow_zeros,paddle which still gives the error Invalid dimension to be accessed. Now only supports access to dimension 0 to 9, but received dimension is 10.. Could you perhaps update and test. Thanks 🙂️

Thanks for the suggestions @Ishticode , I have update the test code with the suggested changes!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thank you for this PR, here is the CI results:


Failed tests:

This PR introduces the following new failing tests:
ivy_tests/test_ivy/test_functional/test_experimental/test_core/test_elementwise.py::test_diff,paddle
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,numpy
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,jax
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,tensorflow
ivy_tests/test_ivy/test_frontends/test_tensorflow/test_math.py::test_tensorflow_scalar_mul,torch

@Ishticode Ishticode merged commit 5173e82 into ivy-llc:main Mar 28, 2024
134 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TensorFlow Zeros API at Ivy Frontend: Limitation with Paddle Backend Supports Only Dimensions 0 to 9
4 participants