Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add negative_ method to PyTorch frontend #23766

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

daspartho
Copy link
Contributor

@daspartho daspartho commented Sep 17, 2023

Close #23760

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@daspartho daspartho changed the title Add negative_ method to PyTorch frontend feat:Add negative_ method to PyTorch frontend Sep 17, 2023
@daspartho daspartho changed the title feat:Add negative_ method to PyTorch frontend feat: Add negative_ method to PyTorch frontend Sep 17, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

  • We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
    • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
    • New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, so be patient.

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 17, 2023
@daspartho daspartho mentioned this pull request Sep 17, 2023
@daspartho
Copy link
Contributor Author

2 tests are failing but I don't know what's causing it, could you provide me with some context?

@daspartho
Copy link
Contributor Author

Hey @RickSanchezStoic could you take a look at it, looking forward to any comments!

@RickSanchezStoic
Copy link
Contributor

@RashulChutani same issue here, dill not found

@daspartho
Copy link
Contributor Author

hello @RickSanchezStoic any updates on this?

@daspartho
Copy link
Contributor Author

@RickSanchezStoic any updates?

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daspartho
Thank you very much for the PR. Sorry for the delay. Not sure why this wasn't merged earlier. Thank you very much for contributing :)

@Ishticode Ishticode merged commit 78df55e into ivy-llc:main Feb 29, 2024
272 of 277 checks passed
@daspartho daspartho deleted the negative_ branch March 3, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

negative_
5 participants