-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
index_add #26394
index_add #26394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
@saeedashrraf please have a look at my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge upstream/main into your branch please? 😄
@HaiderSultanArc I have merged, have a look now |
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge with upstream/main again? The issue of CI should be fixed now.
I have merged the main. But, I need to make some modifications to the test. Also, I have something to say to you about this frontend function. I shall DM u on Discord. |
@HaiderSultanArc all the tests are passing now but, please don't merge it now until I add this to Ivy Functional API and here replace the code with calling |
Hi @imsoumya18, if you PR is ready, you can let me know for the review. |
Hi @imsoumya18, |
@NiteshK84 it is now passing all tests |
Hi @imsoumya18, |
not sure why a lot of tests are failing in CI. |
PR Description
index_add method in Paddla FrontEnd
Related Issue
index_add #26392
Close #26392
Checklist
Socials
Twitter