Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index_add #26394

Merged
merged 40 commits into from
Jan 9, 2024
Merged

index_add #26394

merged 40 commits into from
Jan 9, 2024

Conversation

imsoumya18
Copy link
Contributor

@imsoumya18 imsoumya18 commented Oct 1, 2023

PR Description

index_add method in Paddla FrontEnd

Related Issue

index_add #26392

Close #26392

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Twitter

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 1, 2023
@imsoumya18
Copy link
Contributor Author

@saeedashrraf please have a look at my PR

Copy link
Contributor

@HaiderSultanArc HaiderSultanArc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge upstream/main into your branch please? 😄

@imsoumya18
Copy link
Contributor Author

@HaiderSultanArc I have merged, have a look now

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

Copy link
Contributor

@HaiderSultanArc HaiderSultanArc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of your tests are failing 🤔 . Can you have a look at your implementation?
image

Copy link
Contributor

@HaiderSultanArc HaiderSultanArc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge with upstream/main again? The issue of CI should be fixed now.

@imsoumya18
Copy link
Contributor Author

Can you merge with upstream/main again? The issue of CI should be fixed now.

I have merged the main. But, I need to make some modifications to the test. Also, I have something to say to you about this frontend function. I shall DM u on Discord.

@imsoumya18
Copy link
Contributor Author

@HaiderSultanArc all the tests are passing now but, please don't merge it now until I add this to Ivy Functional API and here replace the code with calling ivy.index_add API as I have told you on Discord.

@imsoumya18 imsoumya18 mentioned this pull request Dec 8, 2023
5 tasks
@NiteshK84
Copy link
Contributor

Hi @imsoumya18, if you PR is ready, you can let me know for the review.

@NiteshK84 NiteshK84 self-assigned this Dec 26, 2023
@NiteshK84
Copy link
Contributor

Hi @imsoumya18,
test cases for torch and paddle backends are failing, can you please look into it,
image
image

@imsoumya18
Copy link
Contributor Author

@NiteshK84 it is now passing all tests

@NiteshK84
Copy link
Contributor

Hi @imsoumya18,
image
LGTM!

@NiteshK84
Copy link
Contributor

not sure why a lot of tests are failing in CI.

@NiteshK84 NiteshK84 merged commit 11d30f9 into ivy-llc:main Jan 9, 2024
115 of 141 checks passed
@imsoumya18 imsoumya18 mentioned this pull request Jan 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index_add
6 participants