Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed paddle_backend.divide #28063

Merged

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Jan 27, 2024

PR Description

Fix Frontend Failing Test: paddle - miscellaneous.numpy.copysign
image

Fix Frontend Failing Test: paddle - tensor.torch.Tensor.copysign
image

Fix Frontend Failing Test: paddle - spectral_ops.torch.kaiser_window
image

Fix Frontend Failing Test: paddle - signal.tensorflow.signal.kaiser_bessel_derived_window
image

Fix Frontend Failing Test: paddle - math.paddle.rsqrt
image

Fix Frontend Failing Test: paddle - tensor.paddle.Tensor.rsqrt
image

Fix Frontend Failing Test: paddle - tensor.paddle.Tensor.rsqrt_
image

Related Issue

Closes #28061
Closes #28062
Closes #28064
Closes #28065
Closes #28081
Closes #28088
Closes #28089

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@Sarvesh-Kesharwani
Copy link
Contributor

image
image
it works for all the frontend functions you mentioned, but fails for this one, please retest.

@Sai-Suraj-27
Copy link
Contributor Author

Sai-Suraj-27 commented Jan 28, 2024

image image it works for all the frontend functions you mentioned, but fails for this one, please retest.

Hey, @Sarvesh-Kesharwani. Thank you for reviewing. I'm not sure, why test_paddle_rsqrt is failing for you locally. I tested it just now once again, with number of examples set to 150 and all the backends are passing successfully.

image

Also, the TypeError that is shown for you locally, is the exact reason I made this commit (be6fe5d). So, I am not sure why this is failing. Also, even in the CI, it is not shown in failing tests (https://github.com/unifyai/ivy/actions/runs/7679357713/job/20930389707?pr=28063)
Can you please maybe once re-run and see what happens.
Thank you.

@KareemMAX
Copy link
Contributor

Hey @Sai-Suraj-27, everything LGTM. But I'm still worried about @Sarvesh-Kesharwani's case, can you try the falsifying example manually and see how it behave?

@Sarvesh-Kesharwani
Copy link
Contributor

okay, let me retest it once again.

image image it works for all the frontend functions you mentioned, but fails for this one, please retest.

Hey, @Sarvesh-Kesharwani. Thank you for reviewing. I'm not sure, why test_paddle_rsqrt is failing for you locally. I tested it just now once again, with number of examples set to 150 and all the backends are passing successfully.

image

Also, the TypeError that is shown for you locally, is the exact reason I made this commit (be6fe5d). So, I am not sure why this is failing. Also, even in the CI, it is not shown in failing tests (unifyai/ivy/actions/runs/7679357713/job/20930389707?pr=28063) Can you please maybe once re-run and see what happens. Thank you.

@Sarvesh-Kesharwani
Copy link
Contributor

Sarvesh-Kesharwani commented Jan 29, 2024

Hi @Sai-Suraj-27,
I created a new code space with new branch,
still this particular test is failing
image
image

@KareemMAX
Copy link
Contributor

KareemMAX commented Jan 30, 2024

@Sai-Suraj-27, please try to reproduce the error using this snippet:

You can reproduce this example by temporarily adding @reproduce_failure('6.97.1', b'AXicY2AAAkYGCIDRQAAAADYAAw==') as a decorator on your test case

Copied from the image by @Sarvesh-Kesharwani

Also @Sarvesh-Kesharwani, for future reference always show (and copy as text) this reproduce failure tag as it always proves helpful in resolving issues like this

@Sai-Suraj-27
Copy link
Contributor Author

Sai-Suraj-27 commented Jan 30, 2024

@Sai-Suraj-27, please try to reproduce the error using this snippet:

You can reproduce this example by temporarily adding @reproduce_failure('6.97.1', b'AXicY2AAAkYGCIDRQAAAADYAAw==') as a decorator on your test case

Copied from the image by @Sarvesh-Kesharwani

Also @Sarvesh-Kesharwani, for future reference always show (and copy as text) this reproduce failure tag as it always proves helpful in resolving issues like this

Thanks @KareemMAX. I checked with the decorator and it is passing for me
image

Maybe, different version of hypothesis or something else is causing difference (as per the Hypothesis docs)
image.

Since, the test is passing in CI also. I think it is good to merge.

@Sarvesh-Kesharwani Sarvesh-Kesharwani merged commit b33ed80 into Transpile-AI:main Jan 30, 2024
64 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment