Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Ivy Failing Test: paddle - elementwise.divide #28074

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

MuhammadNizamani
Copy link
Contributor

@MuhammadNizamani MuhammadNizamani commented Jan 27, 2024

PR Description

The elementwise divide were failing in paddle because angle function used by paddle divide function and the angle function does not work in integers so to solve this I remove int32 and int64 from elementwise.divide in paddle backend.
all local tests are passing.
elementwise divide

Related Issue

Closes #28069

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@samthakur587
Copy link
Contributor

jsut remove astype from paddle backend. and add these constrain to test function.
test_gradients=st.just(False),
helpers.get_dtypes("numeric",full=False),

@MuhammadNizamani
Copy link
Contributor Author

MuhammadNizamani commented Jan 28, 2024

jsut remove astype from paddle backend. and add these constrain to test function. test_gradients=st.just(False), helpers.get_dtypes("numeric",full=False),

@samthakur587 sir could you elaborate how this solution works please it would great help .
btw thanks sir for your kind reply 🙏🤗

@MuhammadNizamani
Copy link
Contributor Author

@samthakur587 Thanks a lot your suggestion worked and all test are passing
new paddle elementwise divide

@samthakur587
Copy link
Contributor

jsut remove astype from paddle backend. and add these constrain to test function. test_gradients=st.just(False), helpers.get_dtypes("numeric",full=False),

@samthakur587 sir could you elaborate how this solution works please it would great help . btw thanks sir for your kind reply 🙏🤗

LGTM! but as of now the paddle.divide has bug for the int dtype so we are using x1/x2 but if this bug get resolved then we can change it to the paddle.divide .

@samthakur587 samthakur587 changed the title FIX! Fix Ivy Failing Test: paddle - elementwise.divide fix: Fix Ivy Failing Test: paddle - elementwise.divide Feb 5, 2024
@samthakur587 samthakur587 merged commit c856413 into Transpile-AI:main Feb 5, 2024
60 of 145 checks passed
@MuhammadNizamani MuhammadNizamani deleted the elementwise_divide branch February 6, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Ivy Failing Test: paddle - elementwise.divide
4 participants