Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: torch - linalg.torch.linalg.norm #28106

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

shruzki
Copy link
Contributor

@shruzki shruzki commented Jan 29, 2024

Related Issue

Close #27985

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Changes Made

Issue: torch.linalg.norm can take axis of length 1 or 2 (in addition to None). Test allows for axis of length upto 5

@shruzki shruzki changed the title torch.linalg.norm does not allow dim /axis of size more than 2 Fix torch.linalg.norm Jan 29, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@shruzki shruzki changed the title Fix torch.linalg.norm fix: torch.linalg.norm Jan 29, 2024
@shruzki shruzki changed the title fix: torch.linalg.norm Fix Frontend Failing Test: torch - linalg.torch.linalg.norm Jan 29, 2024
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Jan 29, 2024
@NripeshN NripeshN merged commit 1157ec1 into ivy-llc:main Feb 25, 2024
134 of 140 checks passed
Kacper-W-Kozdon pushed a commit to Kacper-W-Kozdon/ivy that referenced this pull request Feb 27, 2024
…28106)

Co-authored-by: NripeshN <86844847+NripeshN@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: torch - linalg.torch.linalg.norm
6 participants